impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Consolidate test and cluster logs under a single directory.
Date Mon, 07 Mar 2016 17:19:42 GMT
Michael Brown has posted comments on this change.

Change subject: Consolidate test and cluster logs under a single directory.
......................................................................


Patch Set 2:

(3 comments)

Has this been tested in an end-to-end Jenkins run yet? I expect there are changes needed to
Impala-auxiliary-tests and likely the Jenkins jobs themselves. Is there a (even informal)
plan for when to merge this and time it so everything still works?

http://gerrit.cloudera.org:8080/#/c/2456/2//COMMIT_MSG
Commit Message:

Line 14: The new structure is as follows:
This structure explanation is really useful. Is there a way to capture this in a README.md
that is added as part of this commit?


http://gerrit.cloudera.org:8080/#/c/2456/2/bin/load-data.py
File bin/load-data.py:

Line 260:     assert os.path.isdir(os.path.join(SQL_OUTPUT_DIR, dataset)), ("Data loading
files "
Could the message also include some hint to the caller as to how to fix the problem?


http://gerrit.cloudera.org:8080/#/c/2456/2/bin/start-impala-cluster.py
File bin/start-impala-cluster.py:

Line 54: parser.add_option("--log_dir", dest="log_dir", default=os.environ['IMPALA_CLUSTER_LOGS_DIR'],
Should this script check for the presence of log_dir now that it doesn't default to /tmp?


-- 
To view, visit http://gerrit.cloudera.org:8080/2456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief1f58f3320ec39d31b3c6bc6ef87f58ff7dfdfa
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message