impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <>
Subject [Impala-CR](cdh5-trunk) Consolidate test and cluster logs under a single directory.
Date Mon, 07 Mar 2016 17:19:42 GMT
Michael Brown has posted comments on this change.

Change subject: Consolidate test and cluster logs under a single directory.

Patch Set 2:


Has this been tested in an end-to-end Jenkins run yet? I expect there are changes needed to
Impala-auxiliary-tests and likely the Jenkins jobs themselves. Is there a (even informal)
plan for when to merge this and time it so everything still works?
Commit Message:

Line 14: The new structure is as follows:
This structure explanation is really useful. Is there a way to capture this in a
that is added as part of this commit?
File bin/

Line 260:     assert os.path.isdir(os.path.join(SQL_OUTPUT_DIR, dataset)), ("Data loading
files "
Could the message also include some hint to the caller as to how to fix the problem?
File bin/

Line 54: parser.add_option("--log_dir", dest="log_dir", default=os.environ['IMPALA_CLUSTER_LOGS_DIR'],
Should this script check for the presence of log_dir now that it doesn't default to /tmp?

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief1f58f3320ec39d31b3c6bc6ef87f58ff7dfdfa
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Alex Behm <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Michael Brown <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message