impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Reduce size of cross-compiled IR
Date Sat, 05 Mar 2016 01:41:12 GMT
Tim Armstrong has posted comments on this change.

Change subject: Reduce size of cross-compiled IR
......................................................................


Patch Set 1:

(1 comment)

I think I got all the hot ones in the agg and join cross-compiled code. I didn't do a complete
audit of the expr cross-compiled code but I think the benefit of that would be marginal. The
optimisation setting I added inlines most of the trivial functions, it's just some of the
more frequently called functions have enough callsites that they don't end up under the inlining
threshold.

http://gerrit.cloudera.org:8080/#/c/2464/1/be/src/codegen/CMakeLists.txt
File be/src/codegen/CMakeLists.txt:

Line 65:   COMMAND ${LLVM_OPT_EXECUTABLE} ${LLVM_OPT_IR_FLAGS} < ${IR_SSE_TMP_OUTPUT_FILE}
> ${IR_SSE_OUTPUT_FILE}
> long lines
We don't seem to wrap lines anywhere in CMake files. Apparently older versions of CMake had
some limitations wiht line wrapping so that may be the reason.


-- 
To view, visit http://gerrit.cloudera.org:8080/2464
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea04ad2e4b365564ee71082657262485d3a85446
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message