impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-2.5.0_5.7.0) OPSAPS-32457: Fix CatalogService Thrift changes to be backwards compatible.
Date Fri, 04 Mar 2016 22:07:53 GMT
Henry Robinson has posted comments on this change.

Change subject: OPSAPS-32457: Fix CatalogService Thrift changes to be backwards compatible.
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2455/2/fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java
File fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java:

Line 1787:     response.result.setUpdated_catalog_object(newTable);
> Technically we don't have to for the BDR problem because that is specific t
I'm not sure I agree. Now every API (except one) uses the legacy interface. Don't we want
to standardise on the new interface as soon as possible? It seems better to have the legacy
use be the exception, not the norm.


-- 
To view, visit http://gerrit.cloudera.org:8080/2455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec04d07c48d7159d2837667d7039046de126a3ad
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.5.0_5.7.0
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Juan Yu <jyu@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message