impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Skye Wanderman-Milne (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-2399: Check for mem limit in allocations in parquet scanner and decompressor
Date Fri, 04 Mar 2016 20:13:54 GMT
Skye Wanderman-Milne has posted comments on this change.

Change subject: IMPALA-2399: Check for mem limit in allocations in parquet scanner and decompressor
......................................................................


Patch Set 10:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2203/10/be/src/exec/hdfs-parquet-scanner.cc
File be/src/exec/hdfs-parquet-scanner.cc:

Line 1681:       if (UNLIKELY(!parse_status_.ok())) continue_execution = false;
> We should move it in the right direction. I just wanted to make sure you we
I don't think we should set parse_status_ to the query status, you'll get log messages like
"Scan node ran into a parse error: <some unrelated error>". Why not set parse_status_
in CommitRows() and keep this logic as-is for now?


-- 
To view, visit http://gerrit.cloudera.org:8080/2203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic70400407b7662999332448f4d1bce2cc344ca89
Gerrit-PatchSet: 10
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message