impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3114: Add a pause monitor for impala processes.
Date Fri, 04 Mar 2016 13:02:29 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-3114: Add a pause monitor for impala processes.
......................................................................


Patch Set 2:

Thanks Tim for your comments. 

- I agree this can be moved to the MaintenanceThread(). However the issue is that the maintenance_thread_
runs every 5seconds ( logbufsec) and there is a chance we might miss pauses. Actually refactoring
MaintenanceThread() to include PauseMonitor()  simplifies the code too but I think this pause
monitor thread should run more frequently. So I didn't make that change. However I moved the
init logic to InitCommonRuntime.

- I too think this doesn't catch hangs in tcmalloc ReleaseFreeMemory calls as it seems to
be holding an internal lock which blocks queries but not pause monitor thread. So I modified
the call a little bit to launch it in a separate thread and monitoring it to log something
if it doesn't complete in 5s. I hard coded it for now, but if the approach is ok, I'll clean
it up.

-- 
To view, visit http://gerrit.cloudera.org:8080/2405
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04eca63c0c44fa8f1b78833080acdc2176372263
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message