impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-2738 Hive/Impala inconsistency in GRANT/REVOKE syntax
Date Thu, 03 Mar 2016 23:52:28 GMT
Thomas Tauber-Marshall has uploaded a new patch set (#4).

Change subject: IMPALA-2738 Hive/Impala inconsistency in GRANT/REVOKE syntax
......................................................................

IMPALA-2738 Hive/Impala inconsistency in GRANT/REVOKE syntax

Added the ability for the "GRANT/REVOKE ALL ON SERVER TO ROLE <role>"
statement to optionally take a server name parameter as:
"GRANT/REVOKE ALL ON SERVER <server> TO ROLE <role>" since Hive
allows this.

The specified server name is checked against the expected server
name from the config during analysis, and an exception is thrown if
they do not match.

Change-Id: Id6c136d9a171ec062d4ff803682d026422497e8b
---
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/com/cloudera/impala/analysis/PrivilegeSpec.java
M fe/src/test/java/com/cloudera/impala/analysis/AnalyzeAuthStmtsTest.java
A testdata/workloads/functional-query/queries/QueryTest/grant_revoke_on_server.test
M tests/authorization/test_grant_revoke.py
5 files changed, 128 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/96/2296/4
-- 
To view, visit http://gerrit.cloudera.org:8080/2296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id6c136d9a171ec062d4ff803682d026422497e8b
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>

Mime
View raw message