impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-2784: codegen PartitionedHashJoinNode::Partition::BuildHashTable()
Date Wed, 02 Mar 2016 17:41:01 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-2784: codegen PartitionedHashJoinNode::Partition::BuildHashTable()
......................................................................


Patch Set 2:

I think we will need to work out an overall strategy for codegen time in Impala 2.6. The LLVM
3.7 upgrade will also regress codegen time (but probably generate slightly better code) so
we're going to have to claw that back somehow, e.g. IMPALA-3066.

We should probably discuss how to approach this offline, but we'll probably want to establish
a baseline before any changes that help or hurt codegen time, then work out how to stage the
changes.

-- 
To view, visit http://gerrit.cloudera.org:8080/2113
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I616f46a861b4909d7a6e66dcf947b3518556768e
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message