impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-2.5.0_5.7.0) IMPALA-3106: Don't allow scanner threads to spin before ranges are issued
Date Wed, 02 Mar 2016 00:43:08 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-3106: Don't allow scanner threads to spin before ranges are issued
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2379/2/be/src/exec/hdfs-scan-node.cc
File be/src/exec/hdfs-scan-node.cc:

Line 1049:     ranges_issued_barrier_.Wait(SCANNER_THREAD_WAIT_TIME_MS, &timed_out);
> If the HdfsScanNode::Open() returns before notifying, I think this thread w
Good catch, done.


-- 
To view, visit http://gerrit.cloudera.org:8080/2379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I064de1ae037b578c70d65503895a920461af877a
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.5.0_5.7.0
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message