impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-2.5.0_5.7.0) IMPALA-3065: Register !empty() predicates as On-clause conjuncts.
Date Wed, 02 Mar 2016 00:01:16 GMT
Hello Marcel Kornacker, Internal Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/2365

to look at the new patch set (#5).

Change subject: IMPALA-3065: Register !empty() predicates as On-clause conjuncts.
......................................................................

IMPALA-3065: Register !empty() predicates as On-clause conjuncts.

The bug was that we incorrectly registered NotEmptyPredicates with
analyzer.registerConjunct() which registers the predicates as
originating from the HAVING-clause. However, a generated !empty()
predicate should only affect the result of the join of its
corresponding rhs CollectionTableRef, and not the whole FROM clause.

This patch also disables generating !empty() predicates if the
parent tuple is outer joined to avoid an incorrect interaction with
our BE projection of collection-typed slots where rows are
incorrectly filtered if the predicate is assigned to a plan node that
comes after the unnest of the collection which also performs the
projection.

Change-Id: I7236940057f6468b085ffb2c228c3146b102cea7
---
M fe/src/main/java/com/cloudera/impala/analysis/CollectionTableRef.java
M testdata/workloads/functional-planner/queries/PlannerTest/nested-collections.test
2 files changed, 58 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/65/2365/5
-- 
To view, visit http://gerrit.cloudera.org:8080/2365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7236940057f6468b085ffb2c228c3146b102cea7
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.5.0_5.7.0
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>

Mime
View raw message