impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Remove redundant row copy in DataStreamSender
Date Tue, 01 Mar 2016 23:31:42 GMT
Hello Marcel Kornacker, Michael Ho, Alex Behm,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/2371

to look at the new patch set (#2).

Change subject: Remove redundant row copy in DataStreamSender
......................................................................

Remove redundant row copy in DataStreamSender

RowBatch::CopyRow() does a shallow copy of tuple pointers, which is
redundant with the tuple pointer copies in the loop immediately
after it.

Change-Id: Ic6603624cb2abc5c8de6f15c9ced73dc3b25a893
---
M be/src/runtime/data-stream-sender.cc
1 file changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/71/2371/2
-- 
To view, visit http://gerrit.cloudera.org:8080/2371
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic6603624cb2abc5c8de6f15c9ced73dc3b25a893
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <skye@cloudera.com>

Mime
View raw message