impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Skye Wanderman-Milne (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3092: Avro table un-queriable after add columns without a default value
Date Tue, 01 Mar 2016 22:52:49 GMT
Skye Wanderman-Milne has posted comments on this change.

Change subject: IMPALA-3092: Avro table un-queriable after add columns without a default value
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2361/1/tests/query_test/test_avro.py
File tests/query_test/test_avro.py:

Line 12: class TestAvroAddColumn(ImpalaTestSuite):
> use column defined version to write this test
You shouldn't need to use alter table, you can just create a table schema that includes columns
not included in the file schema. You can basically copy the "CREATE EXTERNAL TABLE schema_resolution_test"
statement, and then remove the default values from the schema (and also add a record field).
If you look at file_schema1.avsc, it doesn't contain any of the fields defined in the table
schema, so the records1.avro file should exercise the no-default-value codepath.


-- 
To view, visit http://gerrit.cloudera.org:8080/2361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie86421fc3da51086e566998af317faa62ba9789b
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message