impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Remove redundant row copy in DataStreamSender
Date Tue, 01 Mar 2016 21:35:33 GMT
Marcel Kornacker has posted comments on this change.

Change subject: Remove redundant row copy in DataStreamSender
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2371/1/be/src/runtime/data-stream-sender.cc
File be/src/runtime/data-stream-sender.cc:

Line 239:       dest->SetTuple(i, row->GetTuple(i)->DeepCopy(*descs[i],
also fix formatting: don't break up row->...>DeepCopy(), move it to new line instead
(or if you need to, not like this)


-- 
To view, visit http://gerrit.cloudera.org:8080/2371
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6603624cb2abc5c8de6f15c9ced73dc3b25a893
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message