impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-2.5.0_5.7.0) Test for IMPALA-2987
Date Tue, 01 Mar 2016 18:09:49 GMT
Henry Robinson has posted comments on this change.

Change subject: Test for IMPALA-2987
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2306/2/tests/custom_cluster/test_exchange_delays.py
File tests/custom_cluster/test_exchange_delays.py:

Line 28: @CustomClusterTestSuite.with_args("--stress_data_stream_recvr_delay_ms=1000"
       :         " --datastream_timeout_ms=500")
       :   def test_exchange_small_delay(self, vector):
       :     """Test delays in registering data stream receivers where the receiver registers
       :     relatively soon after the timeout.
       :     """
       :     self.run_test_case('QueryTest/exchange-delays', vector)
       : 
       :   @pytest.mark.execute_serially
       :   @CustomClusterTestSuite.with_args("--stress_data_stream_recvr_delay_ms=10000"
       :         " --datastream_timeout_ms=1")
What's the thought behind testing different delays? I worry that in the short delay case it's
quite possible that the sender will arrive fewer than 500ms after the receiver is set up,
particularly in a noisy test environment.


-- 
To view, visit http://gerrit.cloudera.org:8080/2306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5f5746b6023c301bacfa305c525846cdde822c9
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.5.0_5.7.0
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message