impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-2.5.0_5.7.0) IMPALA-3065: Register !empty() predicates as On-clause conjuncts.
Date Tue, 01 Mar 2016 17:12:46 GMT
Hello Marcel Kornacker,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/2365

to look at the new patch set (#3).

Change subject: IMPALA-3065: Register !empty() predicates as On-clause conjuncts.
......................................................................

IMPALA-3065: Register !empty() predicates as On-clause conjuncts.

The bug was that we incorrectly registered NotEmptyPredicates with
analyzer.registerConjunct() which registers the predicates as
originating from the HAVING-clause. However, a generated !empty()
predicate should only affect the result of the join of its
corresponding rhs CollectionTableRef, and not the whole FROM clause.

Change-Id: I7236940057f6468b085ffb2c228c3146b102cea7
---
M fe/src/main/java/com/cloudera/impala/analysis/CollectionTableRef.java
M testdata/workloads/functional-planner/queries/PlannerTest/nested-collections.test
2 files changed, 48 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/65/2365/3
-- 
To view, visit http://gerrit.cloudera.org:8080/2365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7236940057f6468b085ffb2c228c3146b102cea7
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.5.0_5.7.0
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>

Mime
View raw message