Return-Path: X-Original-To: apmail-impala-dev-archive@minotaur.apache.org Delivered-To: apmail-impala-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AABA519349 for ; Sun, 28 Feb 2016 08:04:59 +0000 (UTC) Received: (qmail 24336 invoked by uid 500); 28 Feb 2016 08:04:59 -0000 Delivered-To: apmail-impala-dev-archive@impala.apache.org Received: (qmail 24297 invoked by uid 500); 28 Feb 2016 08:04:59 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 24286 invoked by uid 99); 28 Feb 2016 08:04:59 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 28 Feb 2016 08:04:59 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id CF662C093B for ; Sun, 28 Feb 2016 08:04:58 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id uRuIBZgMrcuy for ; Sun, 28 Feb 2016 08:04:57 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with ESMTPS id ACC445F396 for ; Sun, 28 Feb 2016 08:04:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u1S84oL2003343; Sun, 28 Feb 2016 08:04:50 GMT Date: Sun, 28 Feb 2016 08:04:50 +0000 From: "Sailesh Mukil (Code Review)" To: impala-cr@cloudera.com, dev@impala.incubator.apache.org Message-ID: Reply-To: sailesh@cloudera.com X-Gerrit-MessageType: newchange Subject: =?UTF-8?Q?[Impala-CR](cdh5-2.5.0=5F5.7.0)_IMPALA-3093:_ReopenClient()_could_NULL_out_'client=5Fkey'_causing_a_crash=0A?= X-Gerrit-Change-Id: I16699534d5e48acfc2720f23e420d63af7bd2931 X-Gerrit-ChangeURL: X-Gerrit-Commit: aa6681221be93d50172223322b83b00bd31613e5 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/2338 Change subject: IMPALA-3093: ReopenClient() could NULL out 'client_key' causing a crash ...................................................................... IMPALA-3093: ReopenClient() could NULL out 'client_key' causing a crash When ReopenClient() calls CreateClient() and CreateClient() fails, it sets 'client_key' to NULL. ReopenClient(), then on seeing that CreateClient() has failed has to restore the old client key back to the 'client_key' so that it doesn't remain NULL. However, there was a bug in the logic which made 'old_client_key' and 'client_key' point to the same thing thereby effectively leaving 'client_key' permanently NULLed out (because even old_client_key got NULLed out). This on use (mostly in DoRpc()), caused a crash. This patch fixes the logic so that the correct old client key is restored on a failure to CreateClient(). Change-Id: I16699534d5e48acfc2720f23e420d63af7bd2931 --- M be/src/runtime/client-cache.cc 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/38/2338/1 -- To view, visit http://gerrit.cloudera.org:8080/2338 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I16699534d5e48acfc2720f23e420d63af7bd2931 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.5.0_5.7.0 Gerrit-Owner: Sailesh Mukil