Return-Path: X-Original-To: apmail-impala-dev-archive@minotaur.apache.org Delivered-To: apmail-impala-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6309018786 for ; Fri, 26 Feb 2016 07:15:24 +0000 (UTC) Received: (qmail 70708 invoked by uid 500); 26 Feb 2016 07:15:24 -0000 Delivered-To: apmail-impala-dev-archive@impala.apache.org Received: (qmail 70660 invoked by uid 500); 26 Feb 2016 07:15:24 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 70649 invoked by uid 99); 26 Feb 2016 07:15:24 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Feb 2016 07:15:24 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id AAE98C0C7B for ; Fri, 26 Feb 2016 07:15:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id cyGkydtge_Dz for ; Fri, 26 Feb 2016 07:15:23 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id DDC675F39D for ; Fri, 26 Feb 2016 07:15:22 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u1Q7FLOU013337; Fri, 26 Feb 2016 07:15:21 GMT Message-Id: <201602260715.u1Q7FLOU013337@ip-10-146-233-104.ec2.internal> Date: Fri, 26 Feb 2016 07:15:21 +0000 From: "Michael Ho (Code Review)" To: impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Skye Wanderman-Milne , Huaisi Xu Reply-To: kwho@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-2.5.0=5F5.7.0)_IMPALA-3085:_Unregister_data_sinks'_MemTrackers_at_their_Close()_functions.=0A?= X-Gerrit-Change-Id: I3aec82150a933dc2b261beff41f5f4f022501bfb X-Gerrit-ChangeURL: X-Gerrit-Commit: 3163dc4126f345a5c6a65d3c0671ef16b85b0308 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 Michael Ho has posted comments on this change. Change subject: IMPALA-3085: Unregister data sinks' MemTrackers at their Close() functions. ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/2314/2/be/src/runtime/plan-fragment-executor.h File be/src/runtime/plan-fragment-executor.h: Line 188: /// (e.g. mem_trackers_) from 'runtime_state_' to 'sink_' need to be severed prior to > typo Which word ? Line 189: /// the dtor of 'runtime_state_'. > nit: this might be clearer if you explicitly reset() these scoped ptrs in C I agree but it's a bit hairy as it requires switching the order of Close() and UnregisterQueryResourceMgr() in the destructor. I think it should be okay but it's unclear if there are other dependencies which I may have missed. I will refrain from opening another can of worm at this point of the release but definitely worth trying in the future. -- To view, visit http://gerrit.cloudera.org:8080/2314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3aec82150a933dc2b261beff41f5f4f022501bfb Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.5.0_5.7.0 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Huaisi Xu Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Skye Wanderman-Milne Gerrit-HasComments: Yes