impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Huaisi Xu (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-2.2.0_5.4.x) IMPALA-2621: Fix flaky UNIX_TIMESTAMP() test
Date Sun, 28 Feb 2016 18:52:14 GMT
Hello Internal Jenkins, Dan Hecht,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/2340

to review the following change.

Change subject: IMPALA-2621: Fix flaky UNIX_TIMESTAMP() test
......................................................................

IMPALA-2621: Fix flaky UNIX_TIMESTAMP() test

Previously the test would expect the execution of an expr to be
less than 5 seconds. The test failed presumably because execution
on EC2 took longer. Now the expr result is expected to be between
the time just before the execution started and just after execution
finished.

Change-Id: I88271ab4bd0c3ec85e9cada98a3db00d501b0d2d
Reviewed-on: http://gerrit.cloudera.org:8080/1397
Reviewed-by: Dan Hecht <dhecht@cloudera.com>
Tested-by: Internal Jenkins
(cherry picked from commit 76b2fb7efca3a4a0eb8c4e2975c4d9176faf4983)
---
M be/src/exprs/expr-test.cc
1 file changed, 48 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/40/2340/1
-- 
To view, visit http://gerrit.cloudera.org:8080/2340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I88271ab4bd0c3ec85e9cada98a3db00d501b0d2d
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.2.0_5.4.x
Gerrit-Owner: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Internal Jenkins

Mime
View raw message