impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Todd Lipcon <t...@cloudera.com>
Subject Re: Passing DataLayout to Module/Function Pass Manager of LLVM
Date Wed, 17 Feb 2016 18:15:23 GMT
Regarding the DataLayout question, here's how we handle it with LLVM
3.7 in Kudu:

https://github.com/cloudera/kudu/blob/master/src/kudu/codegen/module_builder.cc#L267

You can see the diff in this mega commit:
https://github.com/cloudera/kudu/commit/9806863e78107505a622b44112a897189d9b3c24

On Wed, Feb 17, 2016 at 10:08 AM, Henry Robinson <henry@cloudera.com> wrote:
> (Moving this conversation to dev@impala.incubator.apache.org,
> impala-dev@cloudera.org to bcc:)
>
> On 17 February 2016 at 09:13, Silvius Rus <srus@cloudera.com> wrote:
>
>> Hey Nishidha,
>>
>> Would you be interested in contributing the changes you've made so far to
>> the Impala ASF project?  It's easier to get help in context if you post a
>> patch for review.  Upgrading to LLVM 3.7 would be beneficial to the project
>> in general, so I think others will jump in to help.
>>
>> https://github.com/cloudera/Impala/wiki/Contributing-to-Impala
>>
>> Silvius
>>
>> On Wed, Feb 17, 2016 at 5:00 AM, nishidha panpaliya <nishidha27@gmail.com>
>> wrote:
>>
>>> Alright Tim. Thanks for the reply.
>>>
>>> Regards,
>>> Nishidha
>>>
>>>
>>> On Tuesday, 16 February 2016 19:16:34 UTC+5:30, nishidha panpaliya wrote:
>>>>
>>>> Hello,
>>>>
>>>> In Impala source code, I've encountered a place in
>>>> be/src/codegen/llvm-codegen.cc where DataLayout's pointer is passed to
>>>> PassManager::addPass method.
>>>>
>>>> module_pass_manager->add(new DataLayout(data_layout_str));
>>>> fn_pass_manager->add(new DataLayout(data_layout_str));
>>>>
>>>>
>>>> *Note*: addPass method is also changed to add in LLVM 3.7.
>>>>
>>>> I wanted to understand what exactly these two lines are doing. What
>>>> would be the impact if they are commented/removed? And if there is any test
>>>> coverage for this?
>>>>
>>>> My rationale behind all these questions is to port Impala on ppc64le,
>>>> I'd to upgrade LLVM 3.3 to 3.7. And in LLVM 3.7, DataLayout is not derived
>>>> from class Pass and hence these lines do not compile with LLVM 3.7. So, I
>>>> need to either find equivalent of this or have to remove.
>>>>
>>>> I'll be grateful to you if you could provide some insights here.
>>>>
>>>> Thanks in advance,
>>>> Nishidha
>>>>
>>>> --
>>> You received this message because you are subscribed to the Google Groups
>>> "Impala Dev" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an
>>> email to impala-dev+unsubscribe@cloudera.org.
>>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Impala Dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to impala-dev+unsubscribe@cloudera.org.
>>
>
>
>
> --
> Henry Robinson
> Software Engineer
> Cloudera
> 415-994-6679



-- 
Todd Lipcon
Software Engineer, Cloudera

Mime
View raw message