impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-2.5.0_5.7.0) IMPALA-2982: lazy initialization of HBase connection
Date Mon, 29 Feb 2016 23:02:51 GMT
Hello Sailesh Mukil,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/2345

to look at the new patch set (#6).

Change subject: IMPALA-2982: lazy initialization of HBase connection
......................................................................

IMPALA-2982: lazy initialization of HBase connection

We shouldn't initialize a HBase connection if Impala will be run on a
cluster without Hbase. This started to bite us with a change to ZK or
HBase that resulted in periodic log messages when a bad HBase connection
was created. This patch changes the logic to only initialize the
question on demand, e.g. when a query is run against a HBase table.

Change-Id: I405f5cbfc62dd4a4aeb6f4019cac358376478884
---
M be/src/runtime/hbase-table-factory.cc
M be/src/runtime/hbase-table-factory.h
M be/src/service/impalad-main.cc
M be/src/testutil/mini-impala-cluster.cc
4 files changed, 40 insertions(+), 32 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/45/2345/6
-- 
To view, visit http://gerrit.cloudera.org:8080/2345
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I405f5cbfc62dd4a4aeb6f4019cac358376478884
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.5.0_5.7.0
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message