impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-2.5.0_5.7.0) IMPALA-3093: ReopenClient() could NULL out 'client_key' causing a crash
Date Sun, 28 Feb 2016 17:27:25 GMT
Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-3093: ReopenClient() could NULL out 'client_key' causing a crash
......................................................................


Patch Set 1:

(1 comment)

> (1 comment)
 > 
 > Great catch! Were you able to reproduce the bug by forcing
 > CreateClient() to fail in that one case?

Yup, I force failed CreateClient() and just as expected, I encountered a crash after ReopenClient().

http://gerrit.cloudera.org:8080/#/c/2338/1/be/src/runtime/client-cache.cc
File be/src/runtime/client-cache.cc:

Line 87: *
> Shouldn't this just be ClientKey?
You're right. Changed it.


-- 
To view, visit http://gerrit.cloudera.org:8080/2338
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16699534d5e48acfc2720f23e420d63af7bd2931
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.5.0_5.7.0
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message