impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-2.5.0_5.7.0) IMPALA-3085: Unregister data sinks' MemTrackers at their Close() functions.
Date Fri, 26 Feb 2016 07:15:21 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-3085: Unregister data sinks' MemTrackers at their Close() functions.
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/2314/2/be/src/runtime/plan-fragment-executor.h
File be/src/runtime/plan-fragment-executor.h:

Line 188:   /// (e.g. mem_trackers_) from 'runtime_state_' to 'sink_' need to be severed prior
to
> typo
Which word ?


Line 189:   /// the dtor of 'runtime_state_'.
> nit: this might be clearer if you explicitly reset() these scoped ptrs in C
I agree but it's a bit hairy as it requires switching the order of Close() and UnregisterQueryResourceMgr()
in the destructor. I think it should be okay but it's unclear if there are other dependencies
which I may have missed. I will refrain from opening another can of worm at this point of
the release but definitely worth trying in the future.


-- 
To view, visit http://gerrit.cloudera.org:8080/2314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3aec82150a933dc2b261beff41f5f4f022501bfb
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.5.0_5.7.0
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message