From commits-return-3166-archive-asf-public=cust-asf.ponee.io@impala.apache.org Thu Feb 15 00:21:14 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6BEBB180656 for ; Thu, 15 Feb 2018 00:21:14 +0100 (CET) Received: (qmail 33694 invoked by uid 500); 14 Feb 2018 23:21:13 -0000 Mailing-List: contact commits-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.apache.org Delivered-To: mailing list commits@impala.apache.org Received: (qmail 33670 invoked by uid 99); 14 Feb 2018 23:21:13 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Feb 2018 23:21:13 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 6E8C1E04FA; Wed, 14 Feb 2018 23:21:13 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: tarmstrong@apache.org To: commits@impala.apache.org Date: Wed, 14 Feb 2018 23:21:14 -0000 Message-Id: In-Reply-To: References: X-Mailer: ASF-Git Admin Mailer Subject: [2/6] impala git commit: IMPALA-6516: Log catalog update only if the catalog version changes IMPALA-6516: Log catalog update only if the catalog version changes Impalad writes a line of log whenever a statestore catalog update comes in. This patch removes the logging when the catalog version doesn't change. Change-Id: I04b8dd05c588d4cd91e9ca2251f8f66325bb45e2 Reviewed-on: http://gerrit.cloudera.org:8080/9311 Reviewed-by: Michael Ho Reviewed-by: anujphadke Reviewed-by: Alex Behm Tested-by: Impala Public Jenkins Project: http://git-wip-us.apache.org/repos/asf/impala/repo Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/d45de474 Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/d45de474 Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/d45de474 Branch: refs/heads/master Commit: d45de4747c57fdfb6b88f30a4b4b7685696277fc Parents: d7f2ce1 Author: Tianyi Wang Authored: Tue Feb 13 13:21:35 2018 -0800 Committer: Impala Public Jenkins Committed: Wed Feb 14 05:26:48 2018 +0000 ---------------------------------------------------------------------- be/src/service/impala-server.cc | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/impala/blob/d45de474/be/src/service/impala-server.cc ---------------------------------------------------------------------- diff --git a/be/src/service/impala-server.cc b/be/src/service/impala-server.cc index 9898029..d5be4dc 100644 --- a/be/src/service/impala-server.cc +++ b/be/src/service/impala-server.cc @@ -1347,13 +1347,15 @@ void ImpalaServer::CatalogUpdateCallback( } else { { unique_lock unique_lock(catalog_version_lock_); + if (catalog_update_info_.catalog_version != resp.new_catalog_version) { + LOG(INFO) << "Catalog topic update applied with version: " << + resp.new_catalog_version << " new min catalog object version: " << + resp.min_catalog_object_version; + } catalog_update_info_.catalog_version = resp.new_catalog_version; catalog_update_info_.catalog_topic_version = delta.to_version; catalog_update_info_.catalog_service_id = resp.catalog_service_id; catalog_update_info_.min_catalog_object_version = resp.min_catalog_object_version; - LOG(INFO) << "Catalog topic update applied with version: " << - resp.new_catalog_version << " new min catalog object version: " << - resp.min_catalog_object_version; catalog_update_info_.UpdateCatalogVersionMetrics(); } ImpaladMetrics::CATALOG_READY->SetValue(resp.new_catalog_version > 0);