impala-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tarmstr...@apache.org
Subject [3/3] impala git commit: IMPALA-3916: Change reserved_words_version to 2.11.0
Date Mon, 05 Feb 2018 17:26:43 GMT
IMPALA-3916: Change reserved_words_version to 2.11.0

Impala 2.x doesn't reserve any unused words by default.

Change-Id: I5a3e5eac8c09de4517beccf79dcea111264668c2
Reviewed-on: http://gerrit.cloudera.org:8080/9201
Reviewed-by: Alex Behm <alex.behm@cloudera.com>
Tested-by: Impala Public Jenkins


Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/fbe637f6
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/fbe637f6
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/fbe637f6

Branch: refs/heads/2.x
Commit: fbe637f6ec16aba09d5bbca9f9ef20eddf7fa091
Parents: ecf972a
Author: Tianyi Wang <twang@cloudera.com>
Authored: Fri Feb 2 13:17:46 2018 -0800
Committer: Impala Public Jenkins <impala-public-jenkins@gerrit.cloudera.org>
Committed: Sun Feb 4 09:18:10 2018 +0000

----------------------------------------------------------------------
 be/src/common/global-flags.cc      | 2 +-
 fe/src/main/jflex/sql-scanner.flex | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/impala/blob/fbe637f6/be/src/common/global-flags.cc
----------------------------------------------------------------------
diff --git a/be/src/common/global-flags.cc b/be/src/common/global-flags.cc
index 2d832da..c61e99b 100644
--- a/be/src/common/global-flags.cc
+++ b/be/src/common/global-flags.cc
@@ -190,7 +190,7 @@ DEFINE_int32(read_size, 8 * 1024 * 1024, "(Advanced) The preferred I/O
request s
     "increase memory requirements. Decreasing the read size may decrease I/O "
     "throughput.");
 
-DEFINE_string(reserved_words_version, "3.0.0", "Reserved words compatibility version. "
+DEFINE_string(reserved_words_version, "2.11.0", "Reserved words compatibility version. "
     "Reserved words cannot be used as identifiers in SQL. This flag determines the impala"
     " version from which the reserved word list is taken. The value must be one of "
     "[\"2.11.0\", \"3.0.0\"].");

http://git-wip-us.apache.org/repos/asf/impala/blob/fbe637f6/fe/src/main/jflex/sql-scanner.flex
----------------------------------------------------------------------
diff --git a/fe/src/main/jflex/sql-scanner.flex b/fe/src/main/jflex/sql-scanner.flex
index c4ed217..3b8a218 100644
--- a/fe/src/main/jflex/sql-scanner.flex
+++ b/fe/src/main/jflex/sql-scanner.flex
@@ -365,7 +365,7 @@ import org.apache.impala.thrift.TReservedWordsVersion;
     // Default-initilize the static members for FE tests. Outside of FE tests, init() is
     // called again in BackendConfig.create() once the backend configuration is passed to
     // the FE, overwriting this initilization.
-    init(TReservedWordsVersion.IMPALA_3_0);
+    init(TReservedWordsVersion.IMPALA_2_11);
   }
 
   static boolean isReserved(String token) {


Mime
View raw message