impala-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From k...@apache.org
Subject [3/3] impala git commit: IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace()
Date Sat, 27 Jan 2018 00:03:42 GMT
IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace()

This change bumps the threshold of RPC duration above which a RPC
is logged. It's increased from 1 second to 2 minutes which is
a conservative value in order to reduce the amount of logging from
RpczStore::LogTrace() when an Impala demon is busy.

Change-Id: I347b0dea641368e10ba84bc40ec250c26a4f43b2
Reviewed-on: http://gerrit.cloudera.org:8080/9125
Reviewed-by: Michael Ho <kwho@cloudera.com>
Reviewed-by: Mostafa Mokhtar <mmokhtar@cloudera.com>
Tested-by: Impala Public Jenkins


Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/47959067
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/47959067
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/47959067

Branch: refs/heads/master
Commit: 47959067ea79b3406ffc411a95362708514c31b2
Parents: 5ca603a
Author: Michael Ho <kwho@cloudera.com>
Authored: Wed Jan 24 13:58:02 2018 -0800
Committer: Impala Public Jenkins <impala-public-jenkins@gerrit.cloudera.org>
Committed: Fri Jan 26 23:07:47 2018 +0000

----------------------------------------------------------------------
 be/src/rpc/rpc-mgr.cc | 6 ++++++
 1 file changed, 6 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/impala/blob/47959067/be/src/rpc/rpc-mgr.cc
----------------------------------------------------------------------
diff --git a/be/src/rpc/rpc-mgr.cc b/be/src/rpc/rpc-mgr.cc
index 91978bb..d4e8fe1 100644
--- a/be/src/rpc/rpc-mgr.cc
+++ b/be/src/rpc/rpc-mgr.cc
@@ -44,6 +44,9 @@ DECLARE_string(hostname);
 DECLARE_string(principal);
 DECLARE_string(be_principal);
 
+// Defined in kudu/rpc/rpcz_store.cc
+DECLARE_int32(rpc_duration_too_long_ms);
+
 DEFINE_int32(num_acceptor_threads, 2,
     "Number of threads dedicated to accepting connection requests for RPC services");
 DEFINE_int32(num_reactor_threads, 0,
@@ -55,6 +58,9 @@ DEFINE_int32(rpc_retry_interval_ms, 5,
 namespace impala {
 
 Status RpcMgr::Init() {
+  // Log any RPCs which take longer than 2 minutes.
+  FLAGS_rpc_duration_too_long_ms = 2 * 60 * 1000;
+
   MessengerBuilder bld("impala-server");
   const scoped_refptr<MetricEntity> entity(
       METRIC_ENTITY_server.Instantiate(&registry_, "krpc-metrics"));


Mime
View raw message