impala-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jruss...@apache.org
Subject [1/2] impala git commit: IMPALA-6387: Increase wait for Breakpad crash handling
Date Fri, 12 Jan 2018 20:13:05 GMT
Repository: impala
Updated Branches:
  refs/heads/master 5842c8406 -> e0c993003


IMPALA-6387: Increase wait for Breakpad crash handling

It seems that a recent slowdown of our test infrastructure might have
caused Breakpad to take a longer time to write Minidumps. There could
also be a more fundamental issue leading to hangs. To rule this out,
this change increases the default timeout to something larger to allow
the tests to complete.

Change-Id: I84742be9af9444607fde4baf8ea1c0092ff181fe
Reviewed-on: http://gerrit.cloudera.org:8080/9018
Tested-by: Lars Volker <lv@cloudera.com>
Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/6dc7237f
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/6dc7237f
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/6dc7237f

Branch: refs/heads/master
Commit: 6dc7237fc128ae52e85ef9fdd887a1ab4eb2a465
Parents: 5842c84
Author: Lars Volker <lv@cloudera.com>
Authored: Thu Jan 11 10:14:04 2018 -0800
Committer: Lars Volker <lv@cloudera.com>
Committed: Fri Jan 12 17:22:56 2018 +0000

----------------------------------------------------------------------
 tests/custom_cluster/test_breakpad.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/impala/blob/6dc7237f/tests/custom_cluster/test_breakpad.py
----------------------------------------------------------------------
diff --git a/tests/custom_cluster/test_breakpad.py b/tests/custom_cluster/test_breakpad.py
index c9fa79c..a6e85ba 100644
--- a/tests/custom_cluster/test_breakpad.py
+++ b/tests/custom_cluster/test_breakpad.py
@@ -107,7 +107,7 @@ class TestBreakpadBase(CustomClusterTestSuite):
       return self.cluster.statestored and 1 or 0
     raise RuntimeError("Unknown daemon name: %s" % daemon)
 
-  def wait_for_num_processes(self, daemon, num_expected, timeout=5):
+  def wait_for_num_processes(self, daemon, num_expected, timeout=30):
     end = time.time() + timeout
     self.cluster.refresh()
     num_processes = self.get_num_processes(daemon)


Mime
View raw message