impala-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mi...@apache.org
Subject impala git commit: IMPALA-5754: Rollback the exclusion of clang-tidy check for pcg-cpp
Date Tue, 19 Dec 2017 18:45:41 GMT
Repository: impala
Updated Branches:
  refs/heads/master 8047b1dcb -> 061287d91


IMPALA-5754: Rollback the exclusion of clang-tidy check for pcg-cpp

In the commit 4feb4f3a, the third party library pcg-cpp was excluded
from the clang-tidy check. It could make unexpected side effect, so
fixing some warnings from clang-tidy is better than avoidance of the
check.

Change-Id: I591d30373cb13f0eb89afbe16d81b1d3fb783365
Reviewed-on: http://gerrit.cloudera.org:8080/8829
Reviewed-by: Jim Apple <jbapple-impala@apache.org>
Tested-by: Impala Public Jenkins


Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/061287d9
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/061287d9
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/061287d9

Branch: refs/heads/master
Commit: 061287d912d260ffe569ed9fce3e9ce12af2ab68
Parents: 8047b1d
Author: Jinchul <jinchul@gmail.com>
Authored: Wed Dec 13 22:12:33 2017 +0900
Committer: Impala Public Jenkins <impala-public-jenkins@gerrit.cloudera.org>
Committed: Mon Dec 18 18:37:45 2017 +0000

----------------------------------------------------------------------
 be/src/thirdparty/pcg-cpp-0.98/include/pcg_extras.hpp | 12 ++++++++++++
 bin/run_clang_tidy.sh                                 |  3 +--
 2 files changed, 13 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/impala/blob/061287d9/be/src/thirdparty/pcg-cpp-0.98/include/pcg_extras.hpp
----------------------------------------------------------------------
diff --git a/be/src/thirdparty/pcg-cpp-0.98/include/pcg_extras.hpp b/be/src/thirdparty/pcg-cpp-0.98/include/pcg_extras.hpp
index ec3e569..8ee5b31 100644
--- a/be/src/thirdparty/pcg-cpp-0.98/include/pcg_extras.hpp
+++ b/be/src/thirdparty/pcg-cpp-0.98/include/pcg_extras.hpp
@@ -34,6 +34,14 @@
 
 #ifndef PCG_EXTRAS_HPP_INCLUDED
 #define PCG_EXTRAS_HPP_INCLUDED 1
+// To avoid of warning: 'PCG_USE_ZEROCHECK_ROTATE_IDIOM' is not defined, evaluates to 0
+#ifndef PCG_USE_ZEROCHECK_ROTATE_IDIOM
+#define PCG_USE_ZEROCHECK_ROTATE_IDIOM 0
+#endif // PCG_USE_ZEROCHECK_ROTATE_IDIOM
+// To avoid of warning: 'PCG_USE_INLINE_ASM' is not defined, evaluates to 0
+#ifndef PCG_USE_INLINE_ASM
+#define PCG_USE_INLINE_ASM 0
+#endif // PCG_USE_INLINE_ASM
 
 #include <cinttypes>
 #include <cstddef>
@@ -591,6 +599,9 @@ public:
  * value.
  */
 
+/* Disable the struct because the non-reproducability makes bugs
+ * harder to diagnose.
+ * warning: expansion of date or time macro is not reproducible
 template <typename IntType>
 struct static_arbitrary_seed {
 private:
@@ -604,6 +615,7 @@ public:
     static constexpr IntType value = fnv(IntType(2166136261U ^ sizeof(IntType)),
                         __DATE__ __TIME__ __FILE__);
 };
+*/
 
 // Sometimes, when debugging or testing, it's handy to be able print the name
 // of a (in human-readable form).  This code allows the idiom:

http://git-wip-us.apache.org/repos/asf/impala/blob/061287d9/bin/run_clang_tidy.sh
----------------------------------------------------------------------
diff --git a/bin/run_clang_tidy.sh b/bin/run_clang_tidy.sh
index 36d46ce..e879b35 100755
--- a/bin/run_clang_tidy.sh
+++ b/bin/run_clang_tidy.sh
@@ -38,8 +38,7 @@ fi
 DIRS=$(ls -d "${IMPALA_HOME}/be/src/"*/ | grep -v gutil | grep -v kudu |\
   grep -v thirdparty | tr '\n' ' ')
 # Include/exclude select thirdparty dirs.
-DIRS=$DIRS$(ls -d "${IMPALA_HOME}/be/src/thirdparty/"*/ | grep -v mpfit |\
-  grep -v pcg-cpp | tr '\n' ' ')
+DIRS=$DIRS$(ls -d "${IMPALA_HOME}/be/src/thirdparty/"*/ | grep -v mpfit | tr '\n' ' ')
 PIPE_DIRS=$(echo "${DIRS}" | tr ' ' '|')
 
 # Reduce the concurrency to one less than the number of cores in the system. Note than


Mime
View raw message