impala-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tarmstr...@apache.org
Subject [3/5] incubator-impala git commit: IMPALA-6188: make test_top_n_reclaim less flaky
Date Thu, 16 Nov 2017 15:39:48 GMT
IMPALA-6188: make test_top_n_reclaim less flaky

Testing:
Previously I needed ~20 iterations to get the test to fail on my local
machine. After these changes I haven't been able to reproduce the
failure

Change-Id: I2bea7b0f770dec362a6df075da4e340402bd1d5d
Reviewed-on: http://gerrit.cloudera.org:8080/8562
Reviewed-by: Jim Apple <jbapple-impala@apache.org>
Tested-by: Impala Public Jenkins


Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/9502e21d
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/9502e21d
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/9502e21d

Branch: refs/heads/master
Commit: 9502e21d0315b60ba2c7dd55c5a3af76bfefd2ea
Parents: 46d1be4
Author: Tim Armstrong <tarmstrong@cloudera.com>
Authored: Wed Nov 15 16:29:18 2017 -0800
Committer: Impala Public Jenkins <impala-public-jenkins@gerrit.cloudera.org>
Committed: Thu Nov 16 04:57:39 2017 +0000

----------------------------------------------------------------------
 tests/query_test/test_queries.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/9502e21d/tests/query_test/test_queries.py
----------------------------------------------------------------------
diff --git a/tests/query_test/test_queries.py b/tests/query_test/test_queries.py
index 04d70fc..47921ac 100644
--- a/tests/query_test/test_queries.py
+++ b/tests/query_test/test_queries.py
@@ -226,7 +226,7 @@ class TestTopNReclaimQuery(ImpalaTestSuite):
 
   # Mem limit empirically selected so that the query fails if tuple pool reclamation
   # is not implemented for TopN
-  MEM_LIMIT = "50m"
+  MEM_LIMIT = "60m"
 
   @classmethod
   def get_workload(self):
@@ -243,6 +243,7 @@ class TestTopNReclaimQuery(ImpalaTestSuite):
   def test_top_n_reclaim(self, vector):
     exec_options = vector.get_value('exec_option')
     exec_options['mem_limit'] = self.MEM_LIMIT
+    exec_options['num_scanner_threads'] = 1
     result = self.execute_query(self.QUERY, exec_options)
     runtime_profile = str(result.runtime_profile)
     num_of_times_tuple_pool_reclaimed = re.findall(


Mime
View raw message