impala-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tarmstr...@apache.org
Subject [4/5] incubator-impala git commit: IMPALA-5341: Avoid unintended filter out in fe test
Date Thu, 16 Nov 2017 15:39:49 GMT
IMPALA-5341: Avoid unintended filter out in fe test

Change-Id: Ie79f644a37b0ffab7b0d8e94e77650d56423697a
Reviewed-on: http://gerrit.cloudera.org:8080/8543
Reviewed-by: Alex Behm <alex.behm@cloudera.com>
Tested-by: Impala Public Jenkins


Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/f9155f0d
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/f9155f0d
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/f9155f0d

Branch: refs/heads/master
Commit: f9155f0d8185b3344fe16368806b463fe27bc5c7
Parents: 9502e21
Author: Jinchul <jinchul@gmail.com>
Authored: Tue Nov 14 17:18:59 2017 +0900
Committer: Impala Public Jenkins <impala-public-jenkins@gerrit.cloudera.org>
Committed: Thu Nov 16 09:01:37 2017 +0000

----------------------------------------------------------------------
 fe/src/test/java/org/apache/impala/testutil/TestUtils.java         | 2 +-
 .../functional-planner/queries/PlannerTest/kudu-selectivity.test   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/f9155f0d/fe/src/test/java/org/apache/impala/testutil/TestUtils.java
----------------------------------------------------------------------
diff --git a/fe/src/test/java/org/apache/impala/testutil/TestUtils.java b/fe/src/test/java/org/apache/impala/testutil/TestUtils.java
index 5404455..818c573 100644
--- a/fe/src/test/java/org/apache/impala/testutil/TestUtils.java
+++ b/fe/src/test/java/org/apache/impala/testutil/TestUtils.java
@@ -93,7 +93,7 @@ public class TestUtils {
   static class FileSizeFilter implements ResultFilter {
     private final static String BYTE_FILTER = "[KMGT]?B";
     private final static String NUMBER_FILTER = "\\d+(\\.\\d+)?";
-    private final static String FILTER_KEY = "size=";
+    private final static String FILTER_KEY = " size=";
 
     public boolean matches(String input) { return input.contains(FILTER_KEY); }
 

http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/f9155f0d/testdata/workloads/functional-planner/queries/PlannerTest/kudu-selectivity.test
----------------------------------------------------------------------
diff --git a/testdata/workloads/functional-planner/queries/PlannerTest/kudu-selectivity.test
b/testdata/workloads/functional-planner/queries/PlannerTest/kudu-selectivity.test
index 02843c0..e6c8422 100644
--- a/testdata/workloads/functional-planner/queries/PlannerTest/kudu-selectivity.test
+++ b/testdata/workloads/functional-planner/queries/PlannerTest/kudu-selectivity.test
@@ -154,7 +154,7 @@ Per-Host Resources: mem-estimate=0B mem-reservation=0B
      predicates: id IN (int_col), bigint_col IN (9999999999999999999), double_col IN (CAST('inf'
AS DOUBLE)), float_col IN (CAST('NaN' AS FLOAT)), int_col IN (9999999999), smallint_col IN
(99999, 2), tinyint_col IN (1, 999), bool_col IN (1), string_col NOT IN ('bar')
      kudu predicates: double_col IN (0.0), float_col IN (0.0), bigint_col IN (1, 2), int_col
IN (1, 2), smallint_col IN (0, 2), string_col IN ('foo', 'foo       '), tinyint_col IN (1,
2), bool_col IN (TRUE)
      mem-estimate=0B mem-reservation=0B
-     tuple-ids=0 row-size=126B cardinality=5
+     tuple-ids=0 row-size=97B cardinality=5
 ====
 select * from functional_kudu.alltypes where
 tinyint_col is not null and


Mime
View raw message