impala-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tarmstr...@apache.org
Subject [2/2] incubator-impala git commit: IMPALA-6217: fix DCHECK in Parquet fuzz test
Date Mon, 20 Nov 2017 20:45:42 GMT
IMPALA-6217: fix DCHECK in Parquet fuzz test

The IMPALA-4177 change accidentally removed a Status check that could be
hit with a corrupt parquet file.

Testing:
Ran TestScannersFuzzing in a loop for 2 days.

Change-Id: I6ceca7de31f602b75d744dacbdf37afa75983344
Reviewed-on: http://gerrit.cloudera.org:8080/8594
Reviewed-by: Alex Behm <alex.behm@cloudera.com>
Tested-by: Impala Public Jenkins


Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/690e302a
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/690e302a
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/690e302a

Branch: refs/heads/master
Commit: 690e302a62fac18a2e157f53c9b11280d2fe590e
Parents: 7487c5d
Author: Tim Armstrong <tarmstrong@cloudera.com>
Authored: Sat Nov 18 16:58:16 2017 -0800
Committer: Impala Public Jenkins <impala-public-jenkins@gerrit.cloudera.org>
Committed: Mon Nov 20 20:37:56 2017 +0000

----------------------------------------------------------------------
 be/src/exec/parquet-column-readers.cc | 1 +
 1 file changed, 1 insertion(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/690e302a/be/src/exec/parquet-column-readers.cc
----------------------------------------------------------------------
diff --git a/be/src/exec/parquet-column-readers.cc b/be/src/exec/parquet-column-readers.cc
index 5a2e90e..f5f4f28 100644
--- a/be/src/exec/parquet-column-readers.cc
+++ b/be/src/exec/parquet-column-readers.cc
@@ -375,6 +375,7 @@ class ScalarColumnReader : public BaseScalarColumnReader {
         // TODO: add a fast path here if there's a run of repeated values.
         parent_->parse_status_.MergeStatus(
             def_levels_.CacheNextBatch(num_buffered_values_));
+        if (UNLIKELY(!parent_->parse_status_.ok())) return false;
       }
 
       // Read data page and cached levels to materialize values.


Mime
View raw message