impala-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tarmstr...@apache.org
Subject [1/3] incubator-impala git commit: IMPALA-6155: Allow tests to pass when ORDER BY does not cover the query.
Date Wed, 08 Nov 2017 06:21:14 GMT
Repository: incubator-impala
Updated Branches:
  refs/heads/master 40ec6d008 -> 1ca3adf46


IMPALA-6155: Allow tests to pass when ORDER BY does not cover the query.

Use VERIFY_IS_EQUAL_SORTED tag on RESULTS section to allow low-order
sort deviations to compare.

Testing:
- Passed local tests/run-tests.py ...
- Changed order of expected rows by low-order column and verified test still passes.
- Analyzed all TPC-DS query files for similar patterns, found no others.

Change-Id: Ib42ba64ce6ac9b75b4a532f20cee0055aaed5a6c
Reviewed-on: http://gerrit.cloudera.org:8080/8484
Reviewed-by: Michael Brown <mikeb@cloudera.com>
Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
Tested-by: Impala Public Jenkins


Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/9923b829
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/9923b829
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/9923b829

Branch: refs/heads/master
Commit: 9923b8297a329aa245866e9ed4611ad502b807b7
Parents: 40ec6d0
Author: Tim Wood <twood@cloudera.com>
Authored: Mon Nov 6 15:34:23 2017 -0800
Committer: Impala Public Jenkins <impala-public-jenkins@gerrit.cloudera.org>
Committed: Wed Nov 8 00:13:56 2017 +0000

----------------------------------------------------------------------
 testdata/workloads/tpcds/queries/tpcds-q77a.test | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/9923b829/testdata/workloads/tpcds/queries/tpcds-q77a.test
----------------------------------------------------------------------
diff --git a/testdata/workloads/tpcds/queries/tpcds-q77a.test b/testdata/workloads/tpcds/queries/tpcds-q77a.test
index f5627ff..9076320 100644
--- a/testdata/workloads/tpcds/queries/tpcds-q77a.test
+++ b/testdata/workloads/tpcds/queries/tpcds-q77a.test
@@ -117,7 +117,7 @@ with ss as
 ) foo
 order by channel, id
  limit 100;
----- RESULTS
+---- RESULTS: VERIFY_IS_EQUAL_SORTED
 'catalog channel',1,132885061.65,2050279.74,-12674076.58
 'catalog channel',2,140503047.65,2050279.74,-14906564.08
 'catalog channel',5,130483795.90,2050279.74,-13798294.43


Mime
View raw message