impala-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tarmstr...@apache.org
Subject [1/5] incubator-impala git commit: IMPALA-6206: Fix data load failure with -notests
Date Thu, 23 Nov 2017 04:19:25 GMT
Repository: incubator-impala
Updated Branches:
  refs/heads/master 32baa695f -> c65618182


IMPALA-6206: Fix data load failure with -notests

When tests are not built, specifically with -notests, instead of
just -skiptests, the be-test target is omitted by cmake, and since
nothing in impalad depends on uda/udf samples, they are not built.
This causes data load to fail on a clean build.

Just build them anyway under the target ImpalaUdf since they
build in a few seconds.

This shaves a few minutes off data load testing by avoiding
the time spent linking tests.  Note: only empirically, not
scientifically measured.

Testing: Run a clean build
  find . -name 'libud[af]sample.so'
  ./be/build/debug/udf_samples/libudasample.so
  ./be/build/debug/udf_samples/libudfsample.so

Change-Id: Idaa193989d77d56b72db05ad54e1fb0a345938fb
Reviewed-on: http://gerrit.cloudera.org:8080/8580
Tested-by: Impala Public Jenkins
Reviewed-by: Zach Amsden <zamsden@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/223707d7
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/223707d7
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/223707d7

Branch: refs/heads/master
Commit: 223707d7c99d0d81a5555dbba55e95654686286c
Parents: 32baa69
Author: Zachary Amsden <zamsden@cloudera.com>
Authored: Thu Nov 16 15:43:29 2017 -0800
Committer: Zach Amsden <zamsden@cloudera.com>
Committed: Wed Nov 22 18:49:28 2017 +0000

----------------------------------------------------------------------
 bin/make_impala.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/223707d7/bin/make_impala.sh
----------------------------------------------------------------------
diff --git a/bin/make_impala.sh b/bin/make_impala.sh
index cf05278..8e1807b 100755
--- a/bin/make_impala.sh
+++ b/bin/make_impala.sh
@@ -35,8 +35,8 @@ MAKE_CMD=make
 MAKE_ARGS="-j${IMPALA_BUILD_THREADS:-4} ${IMPALA_MAKE_FLAGS}"
 
 # The minimal make targets if BUILD_EVERYTHING is 0.
-MAKE_TARGETS="impalad statestored catalogd fesupport loggingsupport ImpalaUdf"
-
+MAKE_TARGETS="impalad statestored catalogd fesupport loggingsupport ImpalaUdf \
+    udasample udfsample"
 # parse command line options
 for ARG in $*
 do


Mime
View raw message