impala-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mi...@apache.org
Subject [1/2] incubator-impala git commit: IMPALA-5951: Remove flaky test_catalogd_timeout
Date Mon, 02 Oct 2017 18:24:26 GMT
Repository: incubator-impala
Updated Branches:
  refs/heads/master 64d0dd93e -> c07391ce5


IMPALA-5951: Remove flaky test_catalogd_timeout

test_catalogd_timeout sets a Kudu operation timeout of 1ms and then
performs various Kudu operations which it expects to fail due to a
timeout.

Since the test was written, things have sped up - for example, Impala
used to create a new Kudu client for each operation, but that was
changed in IMPALA-5167, such that the operations now occasionally
complete quickly enough that they don't timeout.

There's not really any way to rewrite this test to ensure that it
won't be flaky, so the patch removes it.

Change-Id: I29fd67d0acc0ee15943c416f2179ad716d2cac05
Reviewed-on: http://gerrit.cloudera.org:8080/8154
Reviewed-by: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Tested-by: Impala Public Jenkins


Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/5d92264c
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/5d92264c
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/5d92264c

Branch: refs/heads/master
Commit: 5d92264c48c23c4cc673e5308cf152d694173f8e
Parents: 64d0dd9
Author: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Authored: Wed Sep 27 08:03:13 2017 -0700
Committer: Impala Public Jenkins <impala-public-jenkins@gerrit.cloudera.org>
Committed: Sat Sep 30 00:50:43 2017 +0000

----------------------------------------------------------------------
 .../QueryTest/kudu-timeouts-catalogd.test       | 27 --------------------
 tests/custom_cluster/test_kudu.py               |  6 -----
 2 files changed, 33 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/5d92264c/testdata/workloads/functional-query/queries/QueryTest/kudu-timeouts-catalogd.test
----------------------------------------------------------------------
diff --git a/testdata/workloads/functional-query/queries/QueryTest/kudu-timeouts-catalogd.test
b/testdata/workloads/functional-query/queries/QueryTest/kudu-timeouts-catalogd.test
deleted file mode 100644
index 63af18d..0000000
--- a/testdata/workloads/functional-query/queries/QueryTest/kudu-timeouts-catalogd.test
+++ /dev/null
@@ -1,27 +0,0 @@
-# TODO: enable this once we have a way to invalidate kudu clients (IMPALA-5685)
-#====
-#---- QUERY
-#show create table functional_kudu.alltypestiny
-#---- CATCH
-#Error opening Kudu table 'impala::functional_kudu.alltypestiny'
-#====
-====
----- QUERY
-# TODO: improve error messages (here and below) when KUDU-1734 is resolved
-describe functional_kudu.alltypes
----- CATCH
-Error opening Kudu table 'impala::functional_kudu.alltypes'
-====
----- QUERY
-create table test_kudu (x int primary key)
-partition by hash(x) partitions 3 stored as kudu
----- CATCH
-Error creating Kudu table
-====
----- QUERY
-create external table test_kudu
-stored as kudu
-tblproperties('kudu.table_name'='doesnt_matter_this_times_out')
----- CATCH
-Error loading schema of table 'doesnt_matter_this_times_out'
-====

http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/5d92264c/tests/custom_cluster/test_kudu.py
----------------------------------------------------------------------
diff --git a/tests/custom_cluster/test_kudu.py b/tests/custom_cluster/test_kudu.py
index 28d1a82..5b447e2 100644
--- a/tests/custom_cluster/test_kudu.py
+++ b/tests/custom_cluster/test_kudu.py
@@ -79,9 +79,3 @@ class TestKuduClientTimeout(CustomClusterTestSuite, KuduTestSuite):
   def test_impalad_timeout(self, vector):
     """Check impalad behavior when -kudu_operation_timeout_ms is too low."""
     self.run_test_case('QueryTest/kudu-timeouts-impalad', vector)
-
-  @pytest.mark.execute_serially
-  @CustomClusterTestSuite.with_args(catalogd_args="-kudu_operation_timeout_ms=1")
-  def test_catalogd_timeout(self, vector):
-    """Check catalogd behavior when -kudu_operation_timeout_ms is too low."""
-    self.run_test_case('QueryTest/kudu-timeouts-catalogd', vector)


Mime
View raw message