impala-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tarmstr...@apache.org
Subject [3/4] incubator-impala git commit: IMPALA-3998: deprecate --refresh_after_connect
Date Thu, 26 Oct 2017 01:50:30 GMT
IMPALA-3998: deprecate --refresh_after_connect

This adds a warning to impala-shell if -r/--refresh_after_connect is
used, in anticipation of us removing the feature in a future version.

Change-Id: Id297f80c0f596a69ef8ecde948812b82d2a5c0fa
Reviewed-on: http://gerrit.cloudera.org:8080/8381
Reviewed-by: Philip Zeyliger <philip@cloudera.com>
Reviewed-by: Bharath Vissapragada <bharathv@cloudera.com>
Tested-by: Impala Public Jenkins


Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/1a74b24b
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/1a74b24b
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/1a74b24b

Branch: refs/heads/master
Commit: 1a74b24bd64d67a420021e1503331581f89cdfff
Parents: c36c34c
Author: Tim Armstrong <tarmstrong@cloudera.com>
Authored: Wed Oct 25 10:55:47 2017 -0700
Committer: Impala Public Jenkins <impala-public-jenkins@gerrit.cloudera.org>
Committed: Wed Oct 25 22:32:10 2017 +0000

----------------------------------------------------------------------
 shell/impala_shell.py | 9 +++++++++
 1 file changed, 9 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/1a74b24b/shell/impala_shell.py
----------------------------------------------------------------------
diff --git a/shell/impala_shell.py b/shell/impala_shell.py
index 8db3e43..502a1cf 100755
--- a/shell/impala_shell.py
+++ b/shell/impala_shell.py
@@ -1262,6 +1262,13 @@ Welcome to the Impala shell.
 """ \
   % (VERSION_STRING, _format_tip(random.choice(TIPS)))
 
+REFRESH_AFTER_CONNECT_DEPRECATION_WARNING = """
++==========================================================================+
+| DEPRECATION WARNING:                                                     |
+| -r/--refresh_after_connect is deprecated and will be removed in a future |
+| version of Impala shell.                                                 |
++==========================================================================+"""
+
 def print_to_stderr(message):
   print >> sys.stderr, message
 
@@ -1442,6 +1449,8 @@ if __name__ == "__main__":
     intro += ("\n\nLDAP authentication is enabled, but the connection to Impala is "
               "not secured by TLS.\nALL PASSWORDS WILL BE SENT IN THE CLEAR TO IMPALA.\n")
 
+  if options.refresh_after_connect:
+    intro += REFRESH_AFTER_CONNECT_DEPRECATION_WARNING
   shell = ImpalaShell(options)
   while shell.is_alive:
     try:


Mime
View raw message