Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D18C5200D0F for ; Fri, 29 Sep 2017 21:14:35 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D01831609BC; Fri, 29 Sep 2017 19:14:35 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 21A391609ED for ; Fri, 29 Sep 2017 21:14:34 +0200 (CEST) Received: (qmail 66781 invoked by uid 500); 29 Sep 2017 19:14:34 -0000 Mailing-List: contact commits-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list commits@impala.incubator.apache.org Received: (qmail 66731 invoked by uid 99); 29 Sep 2017 19:14:34 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Sep 2017 19:14:34 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 6D2861A304E for ; Fri, 29 Sep 2017 19:14:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.222 X-Spam-Level: X-Spam-Status: No, score=-4.222 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id f3IgHH7JUOn9 for ; Fri, 29 Sep 2017 19:14:32 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 7E4165FD48 for ; Fri, 29 Sep 2017 19:14:32 +0000 (UTC) Received: (qmail 66628 invoked by uid 99); 29 Sep 2017 19:14:32 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Sep 2017 19:14:32 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 8E922F5C13; Fri, 29 Sep 2017 19:14:31 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: jrussell@apache.org To: commits@impala.incubator.apache.org Date: Fri, 29 Sep 2017 19:14:35 -0000 Message-Id: In-Reply-To: References: X-Mailer: ASF-Git Admin Mailer Subject: [5/6] incubator-impala git commit: IMPALA-5986: Correct set-option logic to recognize digits in names. archived-at: Fri, 29 Sep 2017 19:14:36 -0000 IMPALA-5986: Correct set-option logic to recognize digits in names. Arose during work for IMPALA-5376; prevents tests from passing consistently. Change-Id: Ia3ba641553ff827dbd4673b9fe7ed7d9d5e83052 Reviewed-on: http://gerrit.cloudera.org:8080/8166 Reviewed-by: Michael Brown Tested-by: Impala Public Jenkins Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/1969c56c Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/1969c56c Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/1969c56c Branch: refs/heads/master Commit: 1969c56c2fba248794d4d52eae4410998afa0709 Parents: a93b7c5 Author: Tim Wood Authored: Thu Sep 28 10:44:23 2017 -0700 Committer: Impala Public Jenkins Committed: Fri Sep 29 01:50:31 2017 +0000 ---------------------------------------------------------------------- tests/common/impala_test_suite.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/1969c56c/tests/common/impala_test_suite.py ---------------------------------------------------------------------- diff --git a/tests/common/impala_test_suite.py b/tests/common/impala_test_suite.py index b0857e9..0732695 100644 --- a/tests/common/impala_test_suite.py +++ b/tests/common/impala_test_suite.py @@ -99,8 +99,8 @@ TARGET_FILESYSTEM = os.getenv("TARGET_FILESYSTEM") or "hdfs" IMPALA_HOME = os.getenv("IMPALA_HOME") EE_TEST_LOGS_DIR = os.getenv("IMPALA_EE_TEST_LOGS_DIR") # Match any SET statement. Assume that query options' names -# only contain alphabets and underscores. -SET_PATTERN = re.compile(r'\s*set\s*([a-zA-Z_]+)=*', re.I) +# only contain alphabets, underscores and digits after position 1. +SET_PATTERN = re.compile(r'\s*set\s*([a-zA-Z_][a-zA-Z0-9_]*)\s*=*', re.I) # Base class for Impala tests. All impala test cases should inherit from this class class ImpalaTestSuite(BaseTestSuite):