Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 610DF200CBD for ; Thu, 22 Jun 2017 00:06:49 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6001B160BF6; Wed, 21 Jun 2017 22:06:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A2634160BD5 for ; Thu, 22 Jun 2017 00:06:48 +0200 (CEST) Received: (qmail 84440 invoked by uid 500); 21 Jun 2017 22:06:47 -0000 Mailing-List: contact commits-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list commits@impala.incubator.apache.org Received: (qmail 84431 invoked by uid 99); 21 Jun 2017 22:06:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Jun 2017 22:06:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 3D3DB1AFBF2 for ; Wed, 21 Jun 2017 22:06:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.222 X-Spam-Level: X-Spam-Status: No, score=-4.222 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id y1065YJg3tBO for ; Wed, 21 Jun 2017 22:06:46 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 206A95F5B3 for ; Wed, 21 Jun 2017 22:06:46 +0000 (UTC) Received: (qmail 84405 invoked by uid 99); 21 Jun 2017 22:06:45 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Jun 2017 22:06:45 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 37A70DFB8A; Wed, 21 Jun 2017 22:06:45 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: tarmstrong@apache.org To: commits@impala.incubator.apache.org Date: Wed, 21 Jun 2017 22:06:45 -0000 Message-Id: <3d9891fb6bfe49ad83a560e57690fe19@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [1/5] incubator-impala git commit: IMPALA-3040 addendum: use specific_build_type_timeout for slow builds archived-at: Wed, 21 Jun 2017 22:06:49 -0000 Repository: incubator-impala Updated Branches: refs/heads/master 235651668 -> 3008a7e66 IMPALA-3040 addendum: use specific_build_type_timeout for slow builds IMPALA-3040 was initially fixed to use a timeout with HDFS caching tests, however some test executions against slow-running builds such as ASAN indicate this timeout may not be high enough. Use the specific_build_type_timeout() method to set a much higher timeout for slower builds such as ASAN. This allows us to virtually ignore timeout values on slow builds, but doesn't force us to unconditionally increase the timeout in a release or debug build. Testing: Ran all tests that use get_num_cache_requests() in a loop 100 times each under an ASAN build. All test iterations passed. Change-Id: I80f1c8a0e634a3726c53ef7297c5b162dd57a3a2 Reviewed-on: http://gerrit.cloudera.org:8080/7115 Reviewed-by: Michael Brown Tested-by: Impala Public Jenkins Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/46ebbab0 Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/46ebbab0 Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/46ebbab0 Branch: refs/heads/master Commit: 46ebbab0cfaaa8a67ddeceb2210a14a999a94733 Parents: 2356516 Author: Michael Brown Authored: Tue Jun 6 10:38:42 2017 -0700 Committer: Impala Public Jenkins Committed: Wed Jun 21 19:16:28 2017 +0000 ---------------------------------------------------------------------- tests/query_test/test_hdfs_caching.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/46ebbab0/tests/query_test/test_hdfs_caching.py ---------------------------------------------------------------------- diff --git a/tests/query_test/test_hdfs_caching.py b/tests/query_test/test_hdfs_caching.py index 96b25ec..6094142 100644 --- a/tests/query_test/test_hdfs_caching.py +++ b/tests/query_test/test_hdfs_caching.py @@ -22,6 +22,7 @@ import re import time from subprocess import check_call +from tests.common.environ import specific_build_type_timeout from tests.common.impala_cluster import ImpalaCluster from tests.common.impala_test_suite import ImpalaTestSuite from tests.common.skip import SkipIfS3, SkipIfADLS, SkipIfIsilon, SkipIfLocal @@ -312,7 +313,8 @@ def get_num_cache_requests(): assert rc == 0, 'Error executing hdfs cacheadmin: %s %s' % (stdout, stderr) return len(stdout.split('\n')) - wait_time_in_sec = 5 + # IMPALA-3040: This can take time, especially under slow builds like ASAN. + wait_time_in_sec = specific_build_type_timeout(5, slow_build_timeout=20) num_stabilization_attempts = 0 max_num_stabilization_attempts = 10 new_requests = None