impala-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From he...@apache.org
Subject [1/2] incubator-impala git commit: IMPALA-5411: Avoid log spew from GetRuntimeProfileStr
Date Thu, 01 Jun 2017 22:55:02 GMT
Repository: incubator-impala
Updated Branches:
  refs/heads/master 9eb0b11a6 -> 9caea9bfa


IMPALA-5411: Avoid log spew from GetRuntimeProfileStr

GetRuntimeProfileStr can potentially log lots of spam to the
coordinator logs if there are clients continuously polling the
web endpoints when the table metadata is still loading. The fix
is to use an appopriate Status constructor that doesn't log it.

Change-Id: I2d0ae8c161346b4ec8c865bc23c5c1cd49c1ce7b
Reviewed-on: http://gerrit.cloudera.org:8080/7042
Reviewed-by: Henry Robinson <henry@cloudera.com>
Tested-by: Impala Public Jenkins


Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/bbc3ce1b
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/bbc3ce1b
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/bbc3ce1b

Branch: refs/heads/master
Commit: bbc3ce1b985d56b9fb2ab95656b7d0ae2b6126ca
Parents: 9eb0b11
Author: Bharath Vissapragada <bharathv@cloudera.com>
Authored: Thu Jun 1 10:16:38 2017 -0700
Committer: Impala Public Jenkins <impala-public-jenkins@gerrit.cloudera.org>
Committed: Thu Jun 1 21:52:19 2017 +0000

----------------------------------------------------------------------
 be/src/service/impala-server.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/bbc3ce1b/be/src/service/impala-server.cc
----------------------------------------------------------------------
diff --git a/be/src/service/impala-server.cc b/be/src/service/impala-server.cc
index 6f47685..434220a 100644
--- a/be/src/service/impala-server.cc
+++ b/be/src/service/impala-server.cc
@@ -601,7 +601,7 @@ Status ImpalaServer::GetRuntimeProfileStr(const TUniqueId& query_id,
     if (request_state.get() != nullptr) {
       // For queries in CREATED state, the profile information isn't populated yet.
       if (request_state->query_state() == beeswax::QueryState::CREATED) {
-        return Status("Query plan is not ready.");
+        return Status::Expected("Query plan is not ready.");
       }
       lock_guard<mutex> l(*request_state->lock());
       if (base64_encoded) {


Mime
View raw message