impala-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sail...@apache.org
Subject [2/3] incubator-impala git commit: IMPALA-5453: test_create_table_like_file fails on enum.parquet
Date Sat, 10 Jun 2017 00:43:13 GMT
IMPALA-5453: test_create_table_like_file fails on enum.parquet

A recent addition to test_create_table_like_file (IMPALA-2525)
relies on a file, enum.parquet, being preloaded into HDFS, which
is done by create-load-data.sh.

The problem is that the test creates the table as an internal
table with its location as the directory containing enum.parquet.

When the test completes and the table is dropped, enum.parquet
is deleted, so the test cannot be successfully run again, and a
snapshot generated from the contents of HDFS afterwards will
not contain the file.

The fix is to create the table as an external table.

Testing:
- Ran the test and verfied enum.parquet is still present in HDFS.

Change-Id: I6c386843e5ef5bf6fc208db1ff90be98fd8baacf
Reviewed-on: http://gerrit.cloudera.org:8080/7139
Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
Reviewed-by: Alex Behm <alex.behm@cloudera.com>
Tested-by: Impala Public Jenkins


Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/6dd50f6d
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/6dd50f6d
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/6dd50f6d

Branch: refs/heads/master
Commit: 6dd50f6d0c6750c9e8e91a9b71c95f464b603f5d
Parents: 1014d76
Author: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Authored: Fri Jun 9 11:44:43 2017 -0700
Committer: Impala Public Jenkins <impala-public-jenkins@gerrit.cloudera.org>
Committed: Fri Jun 9 23:29:17 2017 +0000

----------------------------------------------------------------------
 .../functional-query/queries/QueryTest/create-table-like-file.test | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/6dd50f6d/testdata/workloads/functional-query/queries/QueryTest/create-table-like-file.test
----------------------------------------------------------------------
diff --git a/testdata/workloads/functional-query/queries/QueryTest/create-table-like-file.test
b/testdata/workloads/functional-query/queries/QueryTest/create-table-like-file.test
index a67d450..bd54f3d 100644
--- a/testdata/workloads/functional-query/queries/QueryTest/create-table-like-file.test
+++ b/testdata/workloads/functional-query/queries/QueryTest/create-table-like-file.test
@@ -54,7 +54,7 @@ STRING, STRING, STRING
 ---- QUERY
 # Creating a table from a file containing parquet logical types
 # used to annotate string columns (UTF8, ENUM).
-create table $DATABASE.like_enumtype_file like parquet
+create external table $DATABASE.like_enumtype_file like parquet
 '$FILESYSTEM_PREFIX/test-warehouse/schemas/enum/enum.parquet'
 STORED AS PARQUET
 LOCATION '$FILESYSTEM_PREFIX/test-warehouse/schemas/enum'


Mime
View raw message