impala-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From he...@apache.org
Subject [2/3] incubator-impala git commit: IMPALA-5364: Correct title of query locations table
Date Thu, 01 Jun 2017 17:32:33 GMT
IMPALA-5364: Correct title of query locations table

Previously claimed to be #fragments, but this was inaccurate - it's the
number of queries with fragments on that host.

We should have per-backend reporting on the number of fragment instances
in the future, but for now let's correct the mistaken label.

Change-Id: I2fddd41500ada10eb1c12d92afcb96a82009857b
Reviewed-on: http://gerrit.cloudera.org:8080/6988
Reviewed-by: Henry Robinson <henry@cloudera.com>
Tested-by: Impala Public Jenkins


Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/64e8538a
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/64e8538a
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/64e8538a

Branch: refs/heads/master
Commit: 64e8538ab2a45794821fcf7b84160fdc334e6505
Parents: f7f8c45
Author: Henry Robinson <henry@cloudera.com>
Authored: Wed May 24 20:16:38 2017 -0700
Committer: Impala Public Jenkins <impala-public-jenkins@gerrit.cloudera.org>
Committed: Thu Jun 1 03:33:46 2017 +0000

----------------------------------------------------------------------
 be/src/service/impala-server.cc | 4 ++--
 www/queries.tmpl                | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/64e8538a/be/src/service/impala-server.cc
----------------------------------------------------------------------
diff --git a/be/src/service/impala-server.cc b/be/src/service/impala-server.cc
index 07f6c38..6f47685 100644
--- a/be/src/service/impala-server.cc
+++ b/be/src/service/impala-server.cc
@@ -855,8 +855,8 @@ Status ImpalaServer::ExecuteInternal(
         (*request_state)->schedule()->unique_hosts();
     if (!unique_hosts.empty()) {
       lock_guard<mutex> l(query_locations_lock_);
-      for (const TNetworkAddress& port: unique_hosts) {
-        query_locations_[port].insert((*request_state)->query_id());
+      for (const TNetworkAddress& host: unique_hosts) {
+        query_locations_[host].insert((*request_state)->query_id());
       }
     }
   }

http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/64e8538a/www/queries.tmpl
----------------------------------------------------------------------
diff --git a/www/queries.tmpl b/www/queries.tmpl
index 2f26b92..038f392 100644
--- a/www/queries.tmpl
+++ b/www/queries.tmpl
@@ -147,7 +147,7 @@ archived in memory. The size of that archive is controlled with the
 <table class='table table-hover table-bordered'>
   <tr>
     <th>Location</th>
-    <th>Number of Fragments</th>
+    <th>Number of running queries with fragments on this host</th>
   </tr>
 {{#query_locations}}
   <tr>


Mime
View raw message