impala-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tarmstr...@apache.org
Subject [1/5] incubator-impala git commit: IMPALA-3040 addendum: use specific_build_type_timeout for slow builds
Date Wed, 21 Jun 2017 22:06:45 GMT
Repository: incubator-impala
Updated Branches:
  refs/heads/master 235651668 -> 3008a7e66


IMPALA-3040 addendum: use specific_build_type_timeout for slow builds

IMPALA-3040 was initially fixed to use a timeout with HDFS caching
tests, however some test executions against slow-running builds such as
ASAN indicate this timeout may not be high enough.

Use the specific_build_type_timeout() method to set a much higher
timeout for slower builds such as ASAN. This allows us to virtually
ignore timeout values on slow builds, but doesn't force us to
unconditionally increase the timeout in a release or debug build.

Testing:

Ran all tests that use get_num_cache_requests() in a loop 100 times each
under an ASAN build.  All test iterations passed.

Change-Id: I80f1c8a0e634a3726c53ef7297c5b162dd57a3a2
Reviewed-on: http://gerrit.cloudera.org:8080/7115
Reviewed-by: Michael Brown <mikeb@cloudera.com>
Tested-by: Impala Public Jenkins


Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/46ebbab0
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/46ebbab0
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/46ebbab0

Branch: refs/heads/master
Commit: 46ebbab0cfaaa8a67ddeceb2210a14a999a94733
Parents: 2356516
Author: Michael Brown <mikeb@cloudera.com>
Authored: Tue Jun 6 10:38:42 2017 -0700
Committer: Impala Public Jenkins <impala-public-jenkins@gerrit.cloudera.org>
Committed: Wed Jun 21 19:16:28 2017 +0000

----------------------------------------------------------------------
 tests/query_test/test_hdfs_caching.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/46ebbab0/tests/query_test/test_hdfs_caching.py
----------------------------------------------------------------------
diff --git a/tests/query_test/test_hdfs_caching.py b/tests/query_test/test_hdfs_caching.py
index 96b25ec..6094142 100644
--- a/tests/query_test/test_hdfs_caching.py
+++ b/tests/query_test/test_hdfs_caching.py
@@ -22,6 +22,7 @@ import re
 import time
 from subprocess import check_call
 
+from tests.common.environ import specific_build_type_timeout
 from tests.common.impala_cluster import ImpalaCluster
 from tests.common.impala_test_suite import ImpalaTestSuite
 from tests.common.skip import SkipIfS3, SkipIfADLS, SkipIfIsilon, SkipIfLocal
@@ -312,7 +313,8 @@ def get_num_cache_requests():
     assert rc == 0, 'Error executing hdfs cacheadmin: %s %s' % (stdout, stderr)
     return len(stdout.split('\n'))
 
-  wait_time_in_sec = 5
+  # IMPALA-3040: This can take time, especially under slow builds like ASAN.
+  wait_time_in_sec = specific_build_type_timeout(5, slow_build_timeout=20)
   num_stabilization_attempts = 0
   max_num_stabilization_attempts = 10
   new_requests = None


Mime
View raw message