impala-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tarmstr...@apache.org
Subject [4/7] incubator-impala git commit: IMPALA-3224: De-Cloudera non-docs JIRA URLs
Date Mon, 08 May 2017 21:46:13 GMT
IMPALA-3224: De-Cloudera non-docs JIRA URLs

John Russell is planning to fix the URLS in docs in a separate commit.

Fixed using:

    (git ls-files | xargs replace \
    'https://issues.cloudera.org/browse/IMPALA' 'IMPALA' --) && \
    git checkout HEAD docs

Change-Id: I28ea06e89341de234f9005fdc72a2e43f0ab8182
Reviewed-on: http://gerrit.cloudera.org:8080/6487
Reviewed-by: Jim Apple <jbapple-impala@apache.org>
Tested-by: Impala Public Jenkins


Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/374f1121
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/374f1121
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/374f1121

Branch: refs/heads/master
Commit: 374f1121dab4deb2ac18fd204156f45e3f3221c1
Parents: 5cab97f
Author: Jim Apple <jbapple-impala@apache.org>
Authored: Sat Mar 25 12:57:18 2017 -0700
Committer: Impala Public Jenkins <impala-public-jenkins@gerrit.cloudera.org>
Committed: Sun May 7 04:44:57 2017 +0000

----------------------------------------------------------------------
 .../apache/impala/analysis/CreateTableStmt.java   |  3 +--
 shell/shell_output.py                             |  3 +--
 testdata/bin/compute-table-stats.sh               |  3 +--
 testdata/bin/create-load-data.sh                  | 14 +++++---------
 testdata/bin/load-test-warehouse-snapshot.sh      |  4 ++--
 testdata/bin/setup-hdfs-env.sh                    |  2 +-
 tests/comparison/db_connection.py                 |  3 +--
 tests/comparison/discrepancy_searcher.py          | 18 ++++++++----------
 tests/comparison/query_generator.py               |  4 ++--
 tests/custom_cluster/test_kudu_not_available.py   |  3 +--
 tests/stress/concurrent_select.py                 |  3 +--
 11 files changed, 24 insertions(+), 36 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/374f1121/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
----------------------------------------------------------------------
diff --git a/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java b/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
index 8ee7927..21bcb33 100644
--- a/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
+++ b/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
@@ -247,8 +247,7 @@ public class CreateTableStmt extends StatementBase {
     }
 
     // TODO: Find out what is creating a directory in HDFS and stop doing that. Kudu
-    //       tables shouldn't have HDFS dirs.
-    //       https://issues.cloudera.org/browse/IMPALA-3570
+    //       tables shouldn't have HDFS dirs: IMPALA-3570
     AnalysisUtils.throwIfNotNull(getCachingOp(),
         "A Kudu table cannot be cached in HDFS.");
     AnalysisUtils.throwIfNotNull(getLocation(), "LOCATION cannot be specified for a " +

http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/374f1121/shell/shell_output.py
----------------------------------------------------------------------
diff --git a/shell/shell_output.py b/shell/shell_output.py
index 35ba920..f0cecc8 100644
--- a/shell/shell_output.py
+++ b/shell/shell_output.py
@@ -36,8 +36,7 @@ class PrettyOutputFormatter(object):
     except Exception, e:
       # beeswax returns each row as a tab separated string. If a string column
       # value in a row has tabs, it will break the row split. Default to displaying
-      # raw results. This will change with a move to hiveserver2.
-      # Reference:  https://issues.cloudera.org/browse/IMPALA-116
+      # raw results. This will change with a move to hiveserver2. Reference: IMPALA-116
       error_msg = ("Prettytable cannot resolve string columns values that have "
                    " embedded tabs. Reverting to tab delimited text output")
       print >>sys.stderr, error_msg

http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/374f1121/testdata/bin/compute-table-stats.sh
----------------------------------------------------------------------
diff --git a/testdata/bin/compute-table-stats.sh b/testdata/bin/compute-table-stats.sh
index f06efab..de33017 100755
--- a/testdata/bin/compute-table-stats.sh
+++ b/testdata/bin/compute-table-stats.sh
@@ -24,8 +24,7 @@ trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR
== $LINENO" $0)
 
 . ${IMPALA_HOME}/bin/impala-config.sh > /dev/null 2>&1
 
-# TODO: We need a better way of managing how these get set. See:
-# https://issues.cloudera.org/browse/IMPALA-4346
+# TODO: We need a better way of managing how these get set. See IMPALA-4346
 IMPALAD=${IMPALAD:-localhost:21000}
 
 COMPUTE_STATS_SCRIPT="${IMPALA_HOME}/tests/util/compute_table_stats.py --impalad=${IMPALAD}"

http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/374f1121/testdata/bin/create-load-data.sh
----------------------------------------------------------------------
diff --git a/testdata/bin/create-load-data.sh b/testdata/bin/create-load-data.sh
index 7a351fc..bc24485 100755
--- a/testdata/bin/create-load-data.sh
+++ b/testdata/bin/create-load-data.sh
@@ -35,8 +35,7 @@ trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR
== $LINENO" $0)
 . ${IMPALA_HOME}/testdata/bin/run-step.sh
 
 # Environment variables used to direct the data loading process to an external cluster.
-# TODO: We need a better way of managing how these get set. See:
-# https://issues.cloudera.org/browse/IMPALA-4346
+# TODO: We need a better way of managing how these get set. See IMPALA-4346
 : ${HS2_HOST_PORT=localhost:11050}
 : ${HDFS_NN=localhost:20500}
 : ${IMPALAD=localhost:21000}
@@ -181,8 +180,7 @@ function load-data {
     WORKLOAD="functional"
   fi
 
-  # TODO: Why is there a REMOTE_LOAD condition?
-  # See https://issues.cloudera.org/browse/IMPALA-4347
+  # TODO: Why is there a REMOTE_LOAD condition? See IMPALA-4347
   #
   # Force load the dataset if we detect a schema change.
   if [[ -z "$REMOTE_LOAD" ]]; then
@@ -296,7 +294,7 @@ function copy-and-load-dependent-tables {
   # The error occurs while loading dependent tables.
   #
   # See: logs/data_loading/copy-and-load-dependent-tables.log)
-  # See also: https://issues.cloudera.org/browse/IMPALA-4345
+  # See also: IMPALA-4345
   hadoop fs -chmod -R 777 /tmp/alltypes_rc
   hadoop fs -chmod -R 777 /tmp/alltypes_seq
 
@@ -341,8 +339,7 @@ function load-custom-data {
   # Cleanup the old bad_text_lzo files, if they exist.
   hadoop fs -rm -r -f /test-warehouse/bad_text_lzo/
 
-  # TODO: Why is there a REMOTE_LOAD condition?
-  # See https://issues.cloudera.org/browse/IMPALA-4347
+  # TODO: Why is there a REMOTE_LOAD condition? See IMPALA-4347
   if [[ -z $REMOTE_LOAD ]]; then
     # Index all lzo files in HDFS under /test-warehouse
     ${IMPALA_HOME}/testdata/bin/lzo_indexer.sh /test-warehouse
@@ -414,8 +411,7 @@ function build-and-copy-hive-udfs {
 
 # Additional data loading actions that must be executed after the main data is loaded.
 function custom-post-load-steps {
-  # TODO: Why is there a REMOTE_LOAD condition?
-  # See https://issues.cloudera.org/browse/IMPALA-4347
+  # TODO: Why is there a REMOTE_LOAD condition? See IMPALA-4347
   if [[ -z "$REMOTE_LOAD" ]]; then
     # Configure alltypes_seq as a read-only table. This is required for fe tests.
     # Set both read and execute permissions because accessing the contents of a directory
on

http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/374f1121/testdata/bin/load-test-warehouse-snapshot.sh
----------------------------------------------------------------------
diff --git a/testdata/bin/load-test-warehouse-snapshot.sh b/testdata/bin/load-test-warehouse-snapshot.sh
index 604c8f1..311a9ea 100755
--- a/testdata/bin/load-test-warehouse-snapshot.sh
+++ b/testdata/bin/load-test-warehouse-snapshot.sh
@@ -73,8 +73,8 @@ if [[ "$REPLY" =~ ^[Yy]$ ]]; then
     echo "Creating ${TEST_WAREHOUSE_DIR} directory"
     hadoop fs -mkdir -p ${FILESYSTEM_PREFIX}${TEST_WAREHOUSE_DIR}
 
-    # TODO: commented out because of regressions in local end-to-end testing
-    # See: https://issues.cloudera.org/browse/IMPALA-4345
+    # TODO: commented out because of regressions in local end-to-end testing. See
+    # IMPALA-4345
     #
     # hdfs dfs -chmod 1777 ${FILESYSTEM_PREFIX}${TEST_WAREHOUSE_DIR}
   fi

http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/374f1121/testdata/bin/setup-hdfs-env.sh
----------------------------------------------------------------------
diff --git a/testdata/bin/setup-hdfs-env.sh b/testdata/bin/setup-hdfs-env.sh
index 259cac1..ece94de 100755
--- a/testdata/bin/setup-hdfs-env.sh
+++ b/testdata/bin/setup-hdfs-env.sh
@@ -43,7 +43,7 @@ fi
 
 # TODO: Investigate how to setup encryption keys for running HDFS encryption tests
 # against a remote cluster, rather than the local mini-cluster (i.e., when REMOTE_LOAD
-# is true. See: https://issues.cloudera.org/browse/IMPALA-4344)
+# is true. See: IMPALA-4344)
 
 if [[ $TARGET_FILESYSTEM == hdfs && -z "$REMOTE_LOAD" ]]; then  # Otherwise assume
KMS isn't setup.
   # Create encryption keys for HDFS encryption tests. Keys are stored by the KMS.

http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/374f1121/tests/comparison/db_connection.py
----------------------------------------------------------------------
diff --git a/tests/comparison/db_connection.py b/tests/comparison/db_connection.py
index 8722755..6f9b7ce 100644
--- a/tests/comparison/db_connection.py
+++ b/tests/comparison/db_connection.py
@@ -833,8 +833,7 @@ class ImpalaCursor(DbCursor):
 
   def close(self, quiet=False):
     try:
-      # Explicitly close the operation to avoid issues like
-      # https://issues.cloudera.org/browse/IMPALA-2562.
+      # Explicitly close the operation to avoid issues like IMPALA-2562.
       # This can be remove if https://github.com/cloudera/impyla/pull/142 is merged.
       self._cursor.close_operation()
       self._cursor.close()

http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/374f1121/tests/comparison/discrepancy_searcher.py
----------------------------------------------------------------------
diff --git a/tests/comparison/discrepancy_searcher.py b/tests/comparison/discrepancy_searcher.py
index 6534e4d..ccbdd66 100755
--- a/tests/comparison/discrepancy_searcher.py
+++ b/tests/comparison/discrepancy_searcher.py
@@ -128,10 +128,10 @@ class QueryResultComparator(object):
         if 'Expressions in the ORDER BY clause must not be constant' in error_message \
             or 'Expressions in the PARTITION BY clause must not be consta' in error_message:
           # It's too much work to avoid this bug. Just ignore it if it comes up.
-          known_error = KnownError('https://issues.cloudera.org/browse/IMPALA-1354')
+          known_error = KnownError('IMPALA-1354')
         elif 'GROUP BY expression must not contain aggregate functions' in error_message
\
             or 'select list expression not produced by aggregation output' in error_message:
-          known_error = KnownError('https://issues.cloudera.org/browse/IMPALA-1423')
+          known_error = KnownError('IMPALA-1423')
         elif ('max(' in error_message or 'min(' in error_message) \
             and 'only supported with an UNBOUNDED PRECEDING start bound' in error_message:
           # This analytic isn't supported and ignoring this here is much easier than not
@@ -139,18 +139,18 @@ class QueryResultComparator(object):
           known_error = KnownError('MAX UNBOUNDED PRECISION')
         elif 'IN and/or EXISTS subquery predicates are not supported in binary predicates'
\
             in error_message:
-          known_error = KnownError('https://issues.cloudera.org/browse/IMPALA-1418')
+          known_error = KnownError('IMPALA-1418')
         elif 'Unsupported predicate with subquery' in error_message:
-          known_error = KnownError('https://issues.cloudera.org/browse/IMPALA-1950')
+          known_error = KnownError('IMPALA-1950')
         elif 'RIGHT OUTER JOIN type with no equi-join' in error_message:
-          known_error = KnownError('https://issues.cloudera.org/browse/IMPALA-3063')
+          known_error = KnownError('IMPALA-3063')
         elif 'Operation is in ERROR_STATE' in error_message:
           known_error = KnownError('Mem limit exceeded')
       elif self.test_db_type is db_connection.HIVE:
         if 'ParseException line' in error_message and 'missing ) at' in \
               error_message and query.select_clause and \
               query.select_clause.analytic_items:
-          known_error = KnownError("https://issues.apache.org/jira/browse/HIVE-14871")
+          known_error = KnownError("HIVE-14871")
 
       if known_error:
         comparison_result.exception = known_error
@@ -189,13 +189,11 @@ class QueryResultComparator(object):
             and isinstance(ref_val, (int, float, Decimal)) \
             and abs(ref_val) > BigInt.MAX:
           # Impala will return incorrect results if the val is greater than max BigInt
-          comparison_result.exception = KnownError(
-              'https://issues.cloudera.org/browse/IMPALA-865')
+          comparison_result.exception = KnownError('IMPALA-865')
         elif isinstance(test_val, float) \
             and (isinf(test_val) or isnan(test_val)):
           # In some cases, Impala gives NaNs and Infs instead of NULLs
-          comparison_result.exception = KnownError(
-              'https://issues.cloudera.org/browse/IMPALA-724')
+          comparison_result.exception = KnownError('IMPALA-724')
         comparison_result.ref_row = ref_row
         comparison_result.test_row = test_row
         comparison_result.mismatch_at_row_number = row_idx + 1

http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/374f1121/tests/comparison/query_generator.py
----------------------------------------------------------------------
diff --git a/tests/comparison/query_generator.py b/tests/comparison/query_generator.py
index 22e92f2..be51910 100644
--- a/tests/comparison/query_generator.py
+++ b/tests/comparison/query_generator.py
@@ -514,7 +514,7 @@ class QueryGenerator(object):
               select_item_data_types=select_item_data_types,
               required_table_expr_col_type=join_expr_type,
               require_aggregate=use_agg_subquery,
-              # Don't use UNION + LIMIT; https://issues.cloudera.org/browse/IMPALA-1379
+              # Don't use UNION + LIMIT; IMPALA-1379
               allow_union_clause=(not signature_arg.is_subquery),
               table_alias_prefix=(table_alias_prefix +
                   ('t' if use_correlated_subquery else '')),
@@ -1322,7 +1322,7 @@ class QueryGenerator(object):
       predicate, _ = self._create_boolean_func_tree()
     predicate = self.populate_func_with_vals(
         predicate, val_exprs=basic_select_item_exprs)
-    # https://issues.cloudera.org/browse/IMPALA-1423
+    # IMPALA-1423
     # Make sure any cols used have a table identifier. As of this writing the only
     # single table FROM clauses don't use table aliases. Setting a table alias
     # automatically propagates as a column table identifier ("t1.col" instead of "col").

http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/374f1121/tests/custom_cluster/test_kudu_not_available.py
----------------------------------------------------------------------
diff --git a/tests/custom_cluster/test_kudu_not_available.py b/tests/custom_cluster/test_kudu_not_available.py
index 5fb3df5..090854d 100644
--- a/tests/custom_cluster/test_kudu_not_available.py
+++ b/tests/custom_cluster/test_kudu_not_available.py
@@ -43,8 +43,7 @@ class TestKuduNotAvailable(CustomClusterTestSuite):
         return
       cursor.execute("USE functional_kudu")
 
-      # CREATE TABLE succeeds, the execution is in the frontend only.
-      # https://issues.cloudera.org/browse/IMPALA-3233
+      # CREATE TABLE succeeds, the execution is in the frontend only. See IMPALA-3233
       self.assert_failure("SELECT * FROM tinytable", cursor)
       self.assert_failure("INSERT INTO tinytable VALUES ('a', 'b')", cursor)
       self.assert_failure("DELETE FROM tinytable", cursor)

http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/374f1121/tests/stress/concurrent_select.py
----------------------------------------------------------------------
diff --git a/tests/stress/concurrent_select.py b/tests/stress/concurrent_select.py
index 7aa44b7..b95c427 100755
--- a/tests/stress/concurrent_select.py
+++ b/tests/stress/concurrent_select.py
@@ -900,8 +900,7 @@ class QueryRunner(object):
             op_handle_to_query_id(cursor._last_operation.handle), e)
     caught_msg = str(caught_exception).lower().strip()
 
-    # Exceeding a mem limit may result in the message "cancelled".
-    # https://issues.cloudera.org/browse/IMPALA-2234
+    # Exceeding a mem limit may result in the message "cancelled". See IMPALA-2234
     if "memory limit exceeded" in caught_msg or \
        "repartitioning did not reduce the size of a spilled partition" in caught_msg or \
        caught_msg == "cancelled":


Mime
View raw message