impala-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mjac...@apache.org
Subject incubator-impala git commit: IMPALA-5319: Fix test_hdfs_scan_node_errors failures
Date Wed, 17 May 2017 16:34:33 GMT
Repository: incubator-impala
Updated Branches:
  refs/heads/master 8afb59045 -> 7c368999f


IMPALA-5319: Fix test_hdfs_scan_node_errors failures

The recent Kudu TIMESTAMP patch (IMPALA-5137) made an
inadvertent change [1] to alltypeserror_tmp and
alltypeserrornonulls_tmp, changing 'timestamp_col' from
STRING to TIMESTAMP.

This seems to cause failures on exhaustive jobs which run
test_hdfs_scan_node_errors against all file-formats.
I haven't been able to reproduce this failure myself, so
cannot test whether this fixes the jobs that are failing, but
this change to revert these tables seems warranted given
they were changed inadvertently.

1: https://gerrit.cloudera.org/#/c/6526/11/testdata/datasets/functional/functional_schema_template.sql

Change-Id: I533f1921662802ea6e076eefac973f50c014fcb5
Reviewed-on: http://gerrit.cloudera.org:8080/6891
Reviewed-by: Matthew Jacobs <mj@cloudera.com>
Tested-by: Matthew Jacobs <mj@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/7c368999
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/7c368999
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/7c368999

Branch: refs/heads/master
Commit: 7c368999f8d991b51d440e42a7a4aafab034fe39
Parents: 8afb590
Author: Matthew Jacobs <mj@cloudera.com>
Authored: Mon May 15 14:45:02 2017 -0700
Committer: Matthew Jacobs <mj@cloudera.com>
Committed: Wed May 17 16:34:14 2017 +0000

----------------------------------------------------------------------
 testdata/datasets/functional/functional_schema_template.sql | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/7c368999/testdata/datasets/functional/functional_schema_template.sql
----------------------------------------------------------------------
diff --git a/testdata/datasets/functional/functional_schema_template.sql b/testdata/datasets/functional/functional_schema_template.sql
index 3e068f1..6472226 100644
--- a/testdata/datasets/functional/functional_schema_template.sql
+++ b/testdata/datasets/functional/functional_schema_template.sql
@@ -319,7 +319,7 @@ CREATE EXTERNAL TABLE IF NOT EXISTS {db_name}{db_suffix}.{table_name}_tmp
(
   double_col STRING,
   date_string_col STRING,
   string_col STRING,
-  timestamp_col TIMESTAMP)
+  timestamp_col STRING)
 PARTITIONED BY (year INT, month INT)
 ROW FORMAT DELIMITED
   FIELDS TERMINATED BY ','
@@ -443,7 +443,7 @@ CREATE EXTERNAL TABLE IF NOT EXISTS {db_name}{db_suffix}.{table_name}_tmp
(
   double_col STRING,
   date_string_col STRING,
   string_col STRING,
-  timestamp_col TIMESTAMP)
+  timestamp_col STRING)
 PARTITIONED BY (year INT, month INT)
 ROW FORMAT DELIMITED
   FIELDS TERMINATED BY ','


Mime
View raw message