impala-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jruss...@apache.org
Subject [1/2] incubator-impala git commit: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()
Date Sun, 12 Mar 2017 18:27:02 GMT
Repository: incubator-impala
Updated Branches:
  refs/heads/master f3820e620 -> 56e371664


IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()

GetBytes only sets status in the case of an error. This means that
ReadPageHeader needs to initialize the status variable so that the
status.ok() check is accurate after the GetBytes call.

I verified that the other uses of status are ok. Most do not check
status.ok() directly, but rely on the return value of the function
setting status.

Change-Id: Ie22a8cf6b53f507c378c2efe302482409935184e
Reviewed-on: http://gerrit.cloudera.org:8080/6328
Reviewed-by: Marcel Kornacker <marcel@cloudera.com>
Tested-by: Impala Public Jenkins


Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/244ec22d
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/244ec22d
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/244ec22d

Branch: refs/heads/master
Commit: 244ec22d8e8b2f108f723d49dc95a016a74d6d6f
Parents: f3820e6
Author: Joe McDonnell <joemcdonnell@cloudera.com>
Authored: Thu Mar 9 09:12:12 2017 -0800
Committer: Impala Public Jenkins <impala-public-jenkins@gerrit.cloudera.org>
Committed: Sat Mar 11 05:01:25 2017 +0000

----------------------------------------------------------------------
 be/src/exec/parquet-column-readers.cc | 1 +
 1 file changed, 1 insertion(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/244ec22d/be/src/exec/parquet-column-readers.cc
----------------------------------------------------------------------
diff --git a/be/src/exec/parquet-column-readers.cc b/be/src/exec/parquet-column-readers.cc
index d9f822c..ac74d72 100644
--- a/be/src/exec/parquet-column-readers.cc
+++ b/be/src/exec/parquet-column-readers.cc
@@ -798,6 +798,7 @@ Status BaseScalarColumnReader::ReadPageHeader(bool peek,
 
     // Didn't read entire header, increase buffer size and try again
     int64_t new_buffer_size = max<int64_t>(buffer_size * 2, 1024);
+    status = Status::OK();
     bool success = stream_->GetBytes(
         new_buffer_size, &buffer, &new_buffer_size, &status, /* peek */ true);
     if (!success) {


Mime
View raw message