impala-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ab...@apache.org
Subject incubator-impala git commit: Pass build type to Impala LZO.
Date Fri, 31 Mar 2017 18:23:11 GMT
Repository: incubator-impala
Updated Branches:
  refs/heads/master 4c4235f4b -> 2598e3b26


Pass build type to Impala LZO.

Before, the build type used for Impala LZO was always debug.
Now, the build type is passed from the Impala CMakeLists.txt.

This patch needs corresponding changes to Impala LZO.

Testing: I tested locally with these build types:
DEBUG, RELEASE, and ADDRESS_SANITIZER.

Change-Id: Ia83e594409ad5938662ca210c810d5d31b8637b0
Reviewed-on: http://gerrit.cloudera.org:8080/6446
Reviewed-by: Alex Behm <alex.behm@cloudera.com>
Tested-by: Alex Behm <alex.behm@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/2598e3b2
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/2598e3b2
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/2598e3b2

Branch: refs/heads/master
Commit: 2598e3b26449a03011ab419a4cc1171cee249427
Parents: 4c4235f
Author: Alex Behm <alex.behm@cloudera.com>
Authored: Mon Mar 20 18:15:12 2017 -0700
Committer: Alex Behm <alex.behm@cloudera.com>
Committed: Fri Mar 31 18:21:27 2017 +0000

----------------------------------------------------------------------
 CMakeLists.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/2598e3b2/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 1aff6b7..5e568aa 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -387,7 +387,8 @@ add_custom_target(cscope ALL
 
 if (DEFINED ENV{IMPALA_LZO} AND EXISTS $ENV{IMPALA_LZO})
   add_custom_target(impala-lzo ALL DEPENDS thrift-deps
-    COMMAND $ENV{IMPALA_LZO}/build.sh ${CMAKE_SOURCE_DIR} $ENV{IMPALA_TOOLCHAIN}
+    COMMAND $ENV{IMPALA_LZO}/build.sh ${CMAKE_BUILD_TYPE} ${CMAKE_SOURCE_DIR}
+    $ENV{IMPALA_TOOLCHAIN}
   )
 endif()
 


Mime
View raw message