Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 47A7C200C25 for ; Fri, 24 Feb 2017 22:42:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 4643D160B62; Fri, 24 Feb 2017 21:42:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 91E46160B69 for ; Fri, 24 Feb 2017 22:42:03 +0100 (CET) Received: (qmail 73178 invoked by uid 500); 24 Feb 2017 21:42:02 -0000 Mailing-List: contact commits-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list commits@impala.incubator.apache.org Received: (qmail 73169 invoked by uid 99); 24 Feb 2017 21:42:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Feb 2017 21:42:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 15DC71A0026 for ; Fri, 24 Feb 2017 21:42:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -6.566 X-Spam-Level: X-Spam-Status: No, score=-6.566 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999, SPF_NEUTRAL=0.652, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id KITfSVyCcLsO for ; Fri, 24 Feb 2017 21:42:01 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 320A05F24C for ; Fri, 24 Feb 2017 21:42:00 +0000 (UTC) Received: (qmail 73047 invoked by uid 99); 24 Feb 2017 21:41:59 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Feb 2017 21:41:59 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 53F78DFD9E; Fri, 24 Feb 2017 21:41:59 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: jrussell@apache.org To: commits@impala.incubator.apache.org Date: Fri, 24 Feb 2017 21:41:59 -0000 Message-Id: <5d5dd409a077490b9e085a17fa5436e2@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [1/4] incubator-impala git commit: IMPALA-4981: Re-enable spilling with MT_DOP. archived-at: Fri, 24 Feb 2017 21:42:04 -0000 Repository: incubator-impala Updated Branches: refs/heads/master 1e73d7fc3 -> a71636847 IMPALA-4981: Re-enable spilling with MT_DOP. The initial changes for MT_DOP disabled spilling because spilling is not yet designed/implemented for multi-threaded joins. However, we have since disallowed running queries that have non-local joins with MT_DOP. This patch re-enables spilling with MT_DOP. Change-Id: I86465896c6583be256e17c88a713da7dde25b540 Reviewed-on: http://gerrit.cloudera.org:8080/6131 Reviewed-by: Dan Hecht Reviewed-by: Alex Behm Tested-by: Impala Public Jenkins Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/909be1dd Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/909be1dd Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/909be1dd Branch: refs/heads/master Commit: 909be1dd47fb155f04d700fa9e7429c0f98fdc41 Parents: 1e73d7f Author: Alex Behm Authored: Thu Feb 23 15:57:37 2017 -0800 Committer: Impala Public Jenkins Committed: Fri Feb 24 04:26:24 2017 +0000 ---------------------------------------------------------------------- fe/src/main/java/org/apache/impala/service/Frontend.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/909be1dd/fe/src/main/java/org/apache/impala/service/Frontend.java ---------------------------------------------------------------------- diff --git a/fe/src/main/java/org/apache/impala/service/Frontend.java b/fe/src/main/java/org/apache/impala/service/Frontend.java index 0a4cceb..d3cefa6 100644 --- a/fe/src/main/java/org/apache/impala/service/Frontend.java +++ b/fe/src/main/java/org/apache/impala/service/Frontend.java @@ -1026,8 +1026,7 @@ public class Frontend { queryCtx.client_request.query_options.isDisable_unsafe_spills() && !queryCtx.tables_missing_stats.isEmpty() && !analysisResult.getAnalyzer().hasPlanHints(); - // for now, always disable spilling for multi-threaded execution - if (isMtExec || disableSpilling) queryCtx.setDisable_spilling(true); + queryCtx.setDisable_spilling(disableSpilling); // assign fragment idx int idx = 0;