Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0B5EA200C2D for ; Sat, 18 Feb 2017 00:18:23 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 07591160B6D; Fri, 17 Feb 2017 23:18:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 50FDA160B57 for ; Sat, 18 Feb 2017 00:18:22 +0100 (CET) Received: (qmail 40538 invoked by uid 500); 17 Feb 2017 23:18:21 -0000 Mailing-List: contact commits-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list commits@impala.incubator.apache.org Received: (qmail 40529 invoked by uid 99); 17 Feb 2017 23:18:21 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Feb 2017 23:18:21 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 0C08DC10AA for ; Fri, 17 Feb 2017 23:18:21 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -6.219 X-Spam-Level: X-Spam-Status: No, score=-6.219 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id ySnAXz5eew7r for ; Fri, 17 Feb 2017 23:18:20 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 1B76D5F238 for ; Fri, 17 Feb 2017 23:18:20 +0000 (UTC) Received: (qmail 39444 invoked by uid 99); 17 Feb 2017 23:17:04 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Feb 2017 23:17:04 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id BEA03DFF3E; Fri, 17 Feb 2017 23:17:04 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: mjacobs@apache.org To: commits@impala.incubator.apache.org Date: Fri, 17 Feb 2017 23:17:04 -0000 Message-Id: <270c3be217ca463baf61f6aad4af958a@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [1/9] incubator-impala git commit: IMPALA-4937: Remove unused kudu scanner keep alive variable archived-at: Fri, 17 Feb 2017 23:18:23 -0000 Repository: incubator-impala Updated Branches: refs/heads/master 26eaa2660 -> 815c76f9c IMPALA-4937: Remove unused kudu scanner keep alive variable gflag kudu_scanner_keep_alive_period_us is defined but not used. The same functionality is provided by kudu_scanner_keep_alive_period_sec (in seconds), which works. The kudu_scanner_keep_alive_period_us flag is removed by this patch. Change-Id: I99f56f93f1ff8543cbe415542464a053b24968e2 Reviewed-on: http://gerrit.cloudera.org:8080/6021 Reviewed-by: Sailesh Mukil Reviewed-by: Alex Behm Tested-by: Impala Public Jenkins Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/aee5457a Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/aee5457a Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/aee5457a Branch: refs/heads/master Commit: aee5457a55d78203576b85440bc94fd3f6469fe0 Parents: 26eaa26 Author: Matthew Jacobs Authored: Wed Feb 15 11:01:29 2017 -0800 Committer: Impala Public Jenkins Committed: Thu Feb 16 22:25:13 2017 +0000 ---------------------------------------------------------------------- be/src/exec/kudu-scan-node.cc | 3 --- 1 file changed, 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/aee5457a/be/src/exec/kudu-scan-node.cc ---------------------------------------------------------------------- diff --git a/be/src/exec/kudu-scan-node.cc b/be/src/exec/kudu-scan-node.cc index 630f5b7..a238e3c 100644 --- a/be/src/exec/kudu-scan-node.cc +++ b/be/src/exec/kudu-scan-node.cc @@ -44,9 +44,6 @@ DEFINE_int32(kudu_max_row_batches, 0, "The maximum size of the row batch queue, " " for Kudu scanners."); -DEFINE_int32(kudu_scanner_keep_alive_period_us, 15 * 1000L * 1000L, - "The period at which Kudu Scanners should send keep-alive requests to the tablet " - "server to ensure that scanners do not time out."); using boost::algorithm::to_lower_copy; using kudu::client::KuduClient;