impala-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From he...@apache.org
Subject [3/4] incubator-impala git commit: IMPALA-4920: custom cluster tests: fix generation of py.test options
Date Tue, 14 Feb 2017 21:53:11 GMT
IMPALA-4920: custom cluster tests: fix generation of py.test options

This patch fixes a problem in which unnecessary quote characters were
part of some impala-py.test arguments for running the custom cluster
tests. The bug was causing py.test metadata files as described by the
py.test options --junit-xml and --result-log to end up outside the
intended path for such artifacts. By removing the unnecessary escaped
quotes, custom cluster py.test metadata artifacts will now be in the
proper location. I doubly made sure it was safe to remove these quotes
by adding a space in the RESULTS_DIR. The space isn't expanded but is
instead properly treated as part of RESULTS_DIR.

Change-Id: If6a56bc6bca826a8b50340e5caea7687441899e6
Reviewed-on: http://gerrit.cloudera.org:8080/5978
Reviewed-by: Jim Apple <jbapple-impala@apache.org>
Tested-by: Impala Public Jenkins


Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/9e36088c
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/9e36088c
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/9e36088c

Branch: refs/heads/master
Commit: 9e36088c8d2859bfb862aa19fc1c6b68172a195e
Parents: a53eeb2
Author: Michael Brown <mikeb@cloudera.com>
Authored: Mon Feb 13 09:45:36 2017 -0800
Committer: Impala Public Jenkins <impala-public-jenkins@gerrit.cloudera.org>
Committed: Tue Feb 14 21:09:45 2017 +0000

----------------------------------------------------------------------
 tests/run-custom-cluster-tests.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/9e36088c/tests/run-custom-cluster-tests.sh
----------------------------------------------------------------------
diff --git a/tests/run-custom-cluster-tests.sh b/tests/run-custom-cluster-tests.sh
index 72108f6..ce161b1 100755
--- a/tests/run-custom-cluster-tests.sh
+++ b/tests/run-custom-cluster-tests.sh
@@ -41,8 +41,8 @@ if [[ -d "${AUX_CUSTOM_DIR}" ]]
 then
   ARGS+=("${AUX_CUSTOM_DIR}")
 fi
-ARGS+=("--junitxml=\"${RESULTS_DIR}/TEST-impala-custom-cluster.xml\"")
-ARGS+=("--resultlog=\"${RESULTS_DIR}/TEST-impala-custom-cluster.log\"")
+ARGS+=("--junitxml=${RESULTS_DIR}/TEST-impala-custom-cluster.xml")
+ARGS+=("--resultlog=${RESULTS_DIR}/TEST-impala-custom-cluster.log")
 ARGS+=("$@")
 
 impala-py.test "${ARGS[@]}"


Mime
View raw message