impala-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jruss...@apache.org
Subject [1/4] incubator-impala git commit: IMPALA-4981: Re-enable spilling with MT_DOP.
Date Fri, 24 Feb 2017 21:41:59 GMT
Repository: incubator-impala
Updated Branches:
  refs/heads/master 1e73d7fc3 -> a71636847


IMPALA-4981: Re-enable spilling with MT_DOP.

The initial changes for MT_DOP disabled spilling because
spilling is not yet designed/implemented for multi-threaded
joins. However, we have since disallowed running queries
that have non-local joins with MT_DOP.
This patch re-enables spilling with MT_DOP.

Change-Id: I86465896c6583be256e17c88a713da7dde25b540
Reviewed-on: http://gerrit.cloudera.org:8080/6131
Reviewed-by: Dan Hecht <dhecht@cloudera.com>
Reviewed-by: Alex Behm <alex.behm@cloudera.com>
Tested-by: Impala Public Jenkins


Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/909be1dd
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/909be1dd
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/909be1dd

Branch: refs/heads/master
Commit: 909be1dd47fb155f04d700fa9e7429c0f98fdc41
Parents: 1e73d7f
Author: Alex Behm <alex.behm@cloudera.com>
Authored: Thu Feb 23 15:57:37 2017 -0800
Committer: Impala Public Jenkins <impala-public-jenkins@gerrit.cloudera.org>
Committed: Fri Feb 24 04:26:24 2017 +0000

----------------------------------------------------------------------
 fe/src/main/java/org/apache/impala/service/Frontend.java | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/909be1dd/fe/src/main/java/org/apache/impala/service/Frontend.java
----------------------------------------------------------------------
diff --git a/fe/src/main/java/org/apache/impala/service/Frontend.java b/fe/src/main/java/org/apache/impala/service/Frontend.java
index 0a4cceb..d3cefa6 100644
--- a/fe/src/main/java/org/apache/impala/service/Frontend.java
+++ b/fe/src/main/java/org/apache/impala/service/Frontend.java
@@ -1026,8 +1026,7 @@ public class Frontend {
         queryCtx.client_request.query_options.isDisable_unsafe_spills()
           && !queryCtx.tables_missing_stats.isEmpty()
           && !analysisResult.getAnalyzer().hasPlanHints();
-    // for now, always disable spilling for multi-threaded execution
-    if (isMtExec || disableSpilling) queryCtx.setDisable_spilling(true);
+    queryCtx.setDisable_spilling(disableSpilling);
 
     // assign fragment idx
     int idx = 0;


Mime
View raw message