impala-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tarmstr...@apache.org
Subject incubator-impala git commit: IMPALA-4710: There is an error in control audit log file size number
Date Wed, 28 Dec 2016 18:03:24 GMT
Repository: incubator-impala
Updated Branches:
  refs/heads/master 218ed9215 -> 756231880


IMPALA-4710: There is an error in control audit log file size number

The comparison logic of log file size and maximum config is wrong,
leading to log file size is greater than the maximum config.

This patch corrects the error, makes both are consistent.

Change-Id: I1808d69359102d63b732469b440c9c7675a371b7
Reviewed-on: http://gerrit.cloudera.org:8080/5582
Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
Tested-by: Impala Public Jenkins


Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/75623188
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/75623188
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/75623188

Branch: refs/heads/master
Commit: 756231880880564318b7636e44e9d9f14b556cf0
Parents: 218ed92
Author: davidxdh <davyxdh@163.com>
Authored: Mon Dec 26 17:34:25 2016 +0800
Committer: Impala Public Jenkins <impala-public-jenkins@gerrit.cloudera.org>
Committed: Wed Dec 28 17:58:05 2016 +0000

----------------------------------------------------------------------
 be/src/util/simple-logger.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/75623188/be/src/util/simple-logger.cc
----------------------------------------------------------------------
diff --git a/be/src/util/simple-logger.cc b/be/src/util/simple-logger.cc
index e1ff3d8..9b0592f 100644
--- a/be/src/util/simple-logger.cc
+++ b/be/src/util/simple-logger.cc
@@ -86,7 +86,7 @@ Status SimpleLogger::Init() {
 
 Status SimpleLogger::AppendEntry(const std::string& entry) {
   lock_guard<mutex> l(log_file_lock_);
-  if (num_log_file_entries_ > max_entries_per_file_) {
+  if (num_log_file_entries_ >= max_entries_per_file_) {
     num_log_file_entries_ = 0;
     GenerateLogFileName();
     RETURN_IF_ERROR(FlushInternal());


Mime
View raw message