impala-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From he...@apache.org
Subject [2/2] incubator-impala git commit: IMPALA-4421: Send custom cluster & process failure test results to logs/
Date Fri, 04 Nov 2016 19:57:25 GMT
IMPALA-4421: Send custom cluster & process failure test results to logs/

Improperly nested quotes in tests/run-custom-cluster-tests.sh caused a
directory named "${RESULTS_DIR}" to be created in the tests directory,
which in turned interfered with run-tests.py.

Additonally noticed that run-process-failure-tests.sh was creating a
results directory within tests/. We shoud not be polluting the tests/
dir with random test artifacts, so changed the result directory path
for those tests as well.

Tested by running both scripts, and ensuring that results wound up in
logs/, and nothing was created in tests/.

Change-Id: I475f61b4ba8a693324bbefed8819d029674b66dd
Reviewed-on: http://gerrit.cloudera.org:8080/4918
Reviewed-by: Jim Apple <jbapple@cloudera.com>
Tested-by: Internal Jenkins


Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/381a0f54
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/381a0f54
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/381a0f54

Branch: refs/heads/master
Commit: 381a0f54be6ea1d16c4d65fc7c2747edd388fe8e
Parents: a807b3a
Author: David Knupp <dknupp@cloudera.com>
Authored: Wed Nov 2 12:38:14 2016 -0700
Committer: Internal Jenkins <cloudera-hudson@gerrit.cloudera.org>
Committed: Fri Nov 4 19:40:02 2016 +0000

----------------------------------------------------------------------
 tests/run-custom-cluster-tests.sh  |  5 +++--
 tests/run-process-failure-tests.sh | 12 ++++++------
 2 files changed, 9 insertions(+), 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/381a0f54/tests/run-custom-cluster-tests.sh
----------------------------------------------------------------------
diff --git a/tests/run-custom-cluster-tests.sh b/tests/run-custom-cluster-tests.sh
index adfc02a..72108f6 100755
--- a/tests/run-custom-cluster-tests.sh
+++ b/tests/run-custom-cluster-tests.sh
@@ -41,7 +41,8 @@ if [[ -d "${AUX_CUSTOM_DIR}" ]]
 then
   ARGS+=("${AUX_CUSTOM_DIR}")
 fi
-ARGS+=('--junitxml="${RESULTS_DIR}/TEST-impala-custom-cluster.xml"')
-ARGS+=('--resultlog="${RESULTS_DIR}/TEST-impala-custom-cluster.log"')
+ARGS+=("--junitxml=\"${RESULTS_DIR}/TEST-impala-custom-cluster.xml\"")
+ARGS+=("--resultlog=\"${RESULTS_DIR}/TEST-impala-custom-cluster.log\"")
 ARGS+=("$@")
+
 impala-py.test "${ARGS[@]}"

http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/381a0f54/tests/run-process-failure-tests.sh
----------------------------------------------------------------------
diff --git a/tests/run-process-failure-tests.sh b/tests/run-process-failure-tests.sh
index 2e5f650..9ab531c 100755
--- a/tests/run-process-failure-tests.sh
+++ b/tests/run-process-failure-tests.sh
@@ -25,11 +25,11 @@ trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR
== $LINENO" $0)
 # Disable HEAPCHECK for the process failure tests because they can cause false positives.
 export HEAPCHECK=
 
-RESULTS_DIR=${IMPALA_HOME}/tests/results
-mkdir -p ${RESULTS_DIR}
+RESULTS_DIR="${IMPALA_LOGS_DIR}/process_failure_tests"
+mkdir -p "${RESULTS_DIR}"
 
-cd ${IMPALA_HOME}/tests
-. ${IMPALA_HOME}/bin/set-classpath.sh &> /dev/null
+cd "${IMPALA_HOME}/tests"
+. "${IMPALA_HOME}/bin/set-classpath.sh" &> /dev/null
 impala-py.test experiments/test_process_failures.py \
-    --junitxml="${RESULTS_DIR}/TEST-impala-proc-failure.xml" \
-    --resultlog="${RESULTS_DIR}/TEST-impala-proc-failure.log" "$@"
+    --junitxml="\"${RESULTS_DIR}/TEST-impala-proc-failure.xml\"" \
+    --resultlog="\"${RESULTS_DIR}/TEST-impala-proc-failure.log\"" "$@"


Mime
View raw message