impala-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j..@apache.org
Subject [1/4] incubator-impala git commit: IMPALA-2916: Add warning to query profile if debug build
Date Tue, 18 Oct 2016 15:14:15 GMT
Repository: incubator-impala
Updated Branches:
  refs/heads/master df680cfe3 -> 3f5380dc7


IMPALA-2916: Add warning to query profile if debug build

Change-Id: I85ce4d4a5624382203e6b2c8f5b96d04c4482f37
Reviewed-on: http://gerrit.cloudera.org:8080/4588
Reviewed-by: Henry Robinson <henry@cloudera.com>
Tested-by: Internal Jenkins


Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/0686cc4e
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/0686cc4e
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/0686cc4e

Branch: refs/heads/master
Commit: 0686cc4e1f68b9cdacd6edfb4acb090a7ea0f865
Parents: df680cf
Author: Lars Volker <lv@cloudera.com>
Authored: Sun Oct 2 22:05:19 2016 +0200
Committer: Internal Jenkins <cloudera-hudson@gerrit.cloudera.org>
Committed: Tue Oct 18 06:12:51 2016 +0000

----------------------------------------------------------------------
 be/src/service/query-exec-state.cc | 4 ++++
 1 file changed, 4 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/0686cc4e/be/src/service/query-exec-state.cc
----------------------------------------------------------------------
diff --git a/be/src/service/query-exec-state.cc b/be/src/service/query-exec-state.cc
index 1532ecf..7ec8c27 100644
--- a/be/src/service/query-exec-state.cc
+++ b/be/src/service/query-exec-state.cc
@@ -85,6 +85,10 @@ ImpalaServer::QueryExecState::QueryExecState(
     frontend_(frontend),
     parent_server_(server),
     start_time_(TimestampValue::LocalTime()) {
+#ifndef NDEBUG
+  profile_.AddInfoString("DEBUG MODE WARNING", "Query profile created while running a "
+      "DEBUG build of Impala. Use RELEASE builds to measure query performance.");
+#endif
   row_materialization_timer_ = ADD_TIMER(&server_profile_, "RowMaterializationTimer");
   client_wait_timer_ = ADD_TIMER(&server_profile_, "ClientFetchWaitTimer");
   query_events_ = summary_profile_.AddEventSequence("Query Timeline");


Mime
View raw message